code base for slim GCI control plane test infra #3590
Conversation
Pull Request Functional Test Report for #3590 / 9f220ccVirtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 12072670189Details
💛 - Coveralls |
|
Fails on lemming kne in this PR? See Log Also, can you add a peer team member to review? |
This test case is passed in Lemmings, please find the pass log for your reference. |
| @@ -0,0 +1,36 @@ | |||
| load("//ops/netops/lab/wbb/testbeds:testbeds.bzl", "featureprofiles_test_suite") | |||
There was a problem hiding this comment.
@gopalakrishv We should not push Build file in Git. It will be created internally once the PR is merged
There was a problem hiding this comment.
I have removed the BUILD file
| "testing" | ||
| "time" | ||
|
|
||
| "google3/third_party/open_traffic_generator/gosnappi/gosnappi" |
There was a problem hiding this comment.
Import packages from github.com, google3 is for internal usage. Same applies for all the imports used in this file. Refer internal/otg_helpers/otg_config_helpers/otgconfighelpers.go for reference
There was a problem hiding this comment.
import file paths are updated to gitub
| @@ -0,0 +1,188 @@ | |||
| package basic_static_route_support_test | |||
There was a problem hiding this comment.
I suspect below is a already running same gribi test on lemmings ....
Lemmings SKU defined here -- http://shortn/_qSGuvLKhMn
Also the gribi calls are same as file which does similar test -- http://shortn/_ghVJjmX5gu
might be we just need to validate and confirm that the existing test works.
@dplore any thoughts here?
| @@ -0,0 +1,48 @@ | |||
| # GRIBI static route on lemmings test | |||
There was a problem hiding this comment.
Looks like this has more coverage as well...
If Lemmings SKU(http://shortn/_qSGuvLKhMn) is already covered in existing tests , then we can use the same i guess.
There was a problem hiding this comment.
Purpose of this test case is to give minimum environment for developing the control plane by using the lemmings
…eatureprofiles into gribi_static_route_lemmings
| @@ -0,0 +1,185 @@ | |||
| package gribi_static_route_on_lemmings_test | |||
There was a problem hiding this comment.
probably we want to exclude lemming from the namings here ...
the test seems to be agnostic of platform and the lemmings option is passed as a flag to the test in wbb bind -- use_kne_topo ...
I agree for the need of a simple test in case you want to demo.
There was a problem hiding this comment.
If I remove the lemmings from the name, it will look like a generic one and will be duplicated due to other test cases, which was covering all the aspects, also this coverage is required to have it for Lemming development. We can execute the test case only on Lemming by executing the below command
blaze test --notest_loasd --test_output=streamed --cache_test_results=no -- //third_party/openconfig/featureprofiles/feature/gribi/otg_tests/gribi_static_route_on_lemmings_test:gribi_static_route_on_lemmings_test_kne_openconfig_lemming
There was a problem hiding this comment.
I suspect if we can include platform aspects into the test files... the tests are really platform agnostic....
Also i believe this is not lemmings only test ... the same test should be able to work on other vendors as well... Also, i do not think the other tests cover this simple case right?
- @dplore for any thoughts
There was a problem hiding this comment.
Approving as this is not a blocker to run tests...
@dplore when you have a chance .... please let us know on your thoughts so that we can do it in a seperate change if any is needed.
| @@ -0,0 +1,185 @@ | |||
| package gribi_static_route_on_lemmings_test | |||
There was a problem hiding this comment.
I suspect if we can include platform aspects into the test files... the tests are really platform agnostic....
Also i believe this is not lemmings only test ... the same test should be able to work on other vendors as well... Also, i do not think the other tests cover this simple case right?
- @dplore for any thoughts
| @@ -0,0 +1,185 @@ | |||
| package gribi_static_route_on_lemmings_test | |||
There was a problem hiding this comment.
Approving as this is not a blocker to run tests...
@dplore when you have a chance .... please let us know on your thoughts so that we can do it in a seperate change if any is needed.
* code base for slim GCI control plane test infra * updated the files based on comments * updated based on comments * issues are fixed * textproto issues are fixed
)" (openconfig#3622) This reverts commit 744b8fd.
Developed a code for bring up the control plane test infra with lemmings in KNE topology to work on lemming development activities.
Created a DUT with two IXIA ports connected to the DUT and configured the interfaces, configured the route entry through gRIBI programming.
Same has been validated with the FIB program success acknowledgement.