Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where MTU not getting set for some MTUs #3602

Merged
merged 4 commits into from
Dec 26, 2024

Conversation

mastarkey
Copy link
Contributor

there is an if condition that was set for setting the expected mtu for 1500, this excluded the other two MTU sizes of 5000 and 9236 so added those two types to the if condition as well as they were failing with the got value of nil and want of expected mtu size

@mastarkey mastarkey requested a review from ram-mac as a code owner November 15, 2024 23:32
@OpenConfigBot
Copy link

OpenConfigBot commented Nov 15, 2024

Pull Request Functional Test Report for #3602 / 2e48781

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-5.1: Singleton Interface
Cisco 8000E status
RT-5.1: Singleton Interface
Cisco XRd status
RT-5.1: Singleton Interface
Juniper ncPTX status
RT-5.1: Singleton Interface
Nokia SR Linux status
RT-5.1: Singleton Interface
Openconfig Lemming status
RT-5.1: Singleton Interface

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-5.1: Singleton Interface
Cisco 8808 status
RT-5.1: Singleton Interface
Juniper PTX10008 status
RT-5.1: Singleton Interface
Nokia 7250 IXR-10e status
RT-5.1: Singleton Interface

Help

@ram-mac
Copy link
Contributor

ram-mac commented Dec 26, 2024

The change looks good;

Copy link
Contributor

@ram-mac ram-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12499669086

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12497658317: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@ram-mac ram-mac self-assigned this Dec 26, 2024
@ram-mac ram-mac removed the request for review from dplore December 26, 2024 06:03
Copy link
Contributor

@nsadhasivam nsadhasivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@self-maurya self-maurya merged commit 30cb59a into openconfig:main Dec 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants