fixing bgp_afi_safi_defaults_test with deviations #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Functional Test Report for #3603 / f35a4acVirtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 11964289415Details
💛 - Coveralls |
…the validation is only required for IPv4 unicast at neighbor level
dplore
reviewed
Nov 21, 2024
dplore
previously approved these changes
Nov 21, 2024
dplore
approved these changes
Nov 22, 2024
ANISH-GOTTAPU
pushed a commit
to open-traffic-generator/featureprofiles
that referenced
this pull request
Nov 28, 2024
* fixing bgp_afi_safi_defaults_test with deviations * README modified to add validation for extended nexthop encoding, and the validation is only required for IPv4 unicast at neighbor level * deviations format fix
alshabib
pushed a commit
to alshabib/featureprofiles
that referenced
this pull request
Jan 19, 2025
* fixing bgp_afi_safi_defaults_test with deviations * README modified to add validation for extended nexthop encoding, and the validation is only required for IPv4 unicast at neighbor level * deviations format fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BGP Neighbor Configuration: The script currently configures both IPv4 and IPv6 address families as "true" for both v4 and v6 BGP peers. The Readme specifies that only the corresponding address family should be set to "true" for each peer type. This is fixed now
BGP Capabilities Verification: The script currently retrieves all capabilities for a neighbor and iterates through them. We should instead only retrieve and check the capabilities for the relevant AFI/SAFI family (IPv4 or IPv6). I have implemented a fix for this as well.
Cisco does not support GetAll/Wildcard capability for AFI/SAFI and hence added deviation
Test Case: Validate AFI-SAFI OC Defaults at Peer Group Level:
The argument for BGPv4 peers is incorrectly setting the "isV4Only" parameter to "false."
This is corrected now.
Validate AFI-SAFI Not Enabled: New subsection added to verify only the BGP session and keep validating BGP capabilities as another subtest.
Enabling the extNh.ExtendedNextHopEncoding
This feature is enabled by default for Cisco and we do not have to explicitly enable it via OC path.
Currently added a deviation to set this leaf.