Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RT-5.6 to change link down on port1 instead of all ports #3612

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

ANISH-GOTTAPU
Copy link
Contributor

@OpenConfigBot
Copy link

OpenConfigBot commented Nov 28, 2024

Pull Request Functional Test Report for #3612 / d48a34c

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-5.6: Interface Loopback mode
Cisco 8000E status
RT-5.6: Interface Loopback mode
Cisco XRd status
RT-5.6: Interface Loopback mode
Juniper ncPTX status
RT-5.6: Interface Loopback mode
Nokia SR Linux status
RT-5.6: Interface Loopback mode
Openconfig Lemming status
RT-5.6: Interface Loopback mode

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-5.6: Interface Loopback mode
Cisco 8808 status
RT-5.6: Interface Loopback mode
Juniper PTX10008 status
RT-5.6: Interface Loopback mode
Nokia 7250 IXR-10e status
RT-5.6: Interface Loopback mode

Help

@coveralls
Copy link

coveralls commented Nov 28, 2024

Pull Request Test Coverage Report for Build 12377833113

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12369890154: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@ram-mac
Copy link
Contributor

ram-mac commented Dec 16, 2024

@ANISH-GOTTAPU can you fix the failures in the PR approval workflow and raise request for review again?

@ANISH-GOTTAPU ANISH-GOTTAPU requested a review from a team December 17, 2024 04:28
@ANISH-GOTTAPU
Copy link
Contributor Author

@ANISH-GOTTAPU can you fix the failures in the PR approval workflow and raise request for review again?

@ram-mac : I am getting this as error, can you help me on how to proceed with this.

Match found: File - /feature/interface/interface_loopback_aggregate/otg_tests/interface_loopback_aggregate/interface_loopback_aggregate_test.go, Pattern - /feature/interface/{/**,}
Required codeowners: featureprofiles-maintainers, ram-mac
Required approvals not met: Not all codeowners have approved. and total approvals:0 < minimum approvals:2

@dplore
Copy link
Member

dplore commented Dec 18, 2024

@ANISH-GOTTAPU can you fix the failures in the PR approval workflow and raise request for review again?

@ram-mac : I am getting this as error, can you help me on how to proceed with this.

Match found: File - /feature/interface/interface_loopback_aggregate/otg_tests/interface_loopback_aggregate/interface_loopback_aggregate_test.go, Pattern - /feature/interface/{/**,} Required codeowners: featureprofiles-maintainers, ram-mac Required approvals not met: Not all codeowners have approved. and total approvals:0 < minimum approvals:2

This PR needs two approvers (currently has none).

One approver needs to be the codeowner for feature/interface which is @ram-mac. After he has approved, a reviewer from featureprofiles-approvers must also approve. Then the PR can be merged.

@ram-mac ram-mac assigned ram-mac and unassigned ANISH-GOTTAPU Dec 18, 2024
Copy link
Contributor

@ram-mac ram-mac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ram-mac ram-mac requested a review from rohit-rp December 18, 2024 09:11
@dplore dplore merged commit 7fdbb6e into openconfig:main Dec 18, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants