Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RT-7.3: Fixing IPv6 route generation, DefaultImportPolicy and regexp pattern #3632

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

trathod1
Copy link
Contributor

@trathod1 trathod1 commented Dec 11, 2024

Following changes are made here -

  1. Fixing IPv6 route generation to have AsPath set as expected by Readme test and as it was done for IPv4.
  2. Fixing DefaultImportPolicy for IPv4 to "Reject" as required by eBGP, and as it was before PR-3025
  3. Removing ^ from the regexp aspathMatch at the start, considering these eBGP routes will always have AsPath with neighbor AS 65511 at the start, and will never match ^100

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

…pattern

Following changes are made here -
  1. Fixing IPv6 route generation to have AsPath set as expected by Readme test and as it was done for IPv4.
  2. Fixing DefaultImportPolicy for IPv4 to "Reject" as required by eBGP, and as it was before PR-3025
  3. Removing ^ from the regexp aspathMatch from the beginning, considering these eBGP routes will always AsPath with neighbor AS "65511" at the start, and will never match "^100"

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@OpenConfigBot
Copy link

OpenConfigBot commented Dec 11, 2024

Pull Request Functional Test Report for #3632 / 7de4e45

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-7.3: BGP Policy AS Path Set
Cisco 8000E status
RT-7.3: BGP Policy AS Path Set
Cisco XRd status
RT-7.3: BGP Policy AS Path Set
Juniper ncPTX status
RT-7.3: BGP Policy AS Path Set
Nokia SR Linux status
RT-7.3: BGP Policy AS Path Set
Openconfig Lemming status
RT-7.3: BGP Policy AS Path Set

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-7.3: BGP Policy AS Path Set
Cisco 8808 status
RT-7.3: BGP Policy AS Path Set
Juniper PTX10008 status
RT-7.3: BGP Policy AS Path Set
Nokia 7250 IXR-10e status
RT-7.3: BGP Policy AS Path Set

Help

@trathod1 trathod1 requested review from cfernanz and removed request for cfernanz December 11, 2024 03:21
@coveralls
Copy link

coveralls commented Dec 11, 2024

Pull Request Test Coverage Report for Build 12303370436

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12300163041: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@trathod1
Copy link
Contributor Author

HW log with these changes are available at - b/383732784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants