CISCO deviation for RT-1.26 #3639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikeya-remilla
requested review from
Swetha-haridasula and
a team
as code owners
Pull Request Functional Test Report for #3639 / 22f60fcVirtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 12348960785Details
💛 - Coveralls |
| @@ -1243,3 +1243,8 @@ func EnableTableConnections(dut *ondatra.DUTDevice) bool { | |||
| func NoZeroSuppression(dut *ondatra.DUTDevice) bool { | |||
| return lookupDUTDeviations(dut).GetNoZeroSuppression() | |||
| } | |||
|
|
|||
| // StaticRouteAddRemoveUnsupported returns true if adding/removing static route (static route ECMP feature) is not supported | |||
There was a problem hiding this comment.
kindly add the reference bug here
| b.Set(t, dut) | ||
| validateStaticRoute(t, dut, prefix.cidr(t), sV4) | ||
| if deviations.StaticRouteAddRemoveUnsupported(dut) { | ||
| t.Skip("StaticRouteAddRemove is unsupported") |
There was a problem hiding this comment.
A test case cannot be skipped . A alternate functionality via cli or alternate path has to be added here.
Please refer to 'https://github.com/openconfig/featureprofiles/blob/main/internal/deviations/README.md'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an existing FR request which will be delivered as part of 25.2.1/25.3.1 in 2025.
Adding deviation to avoid false failure on cisco devices.