PLT-1.1 adding breakout config code

[mastarkey]

Test is for breakout config for the following modes

4x100
2x100
4x10

[OpenConfigBot]

Pull Request Functional Test Report for #3648 / 853efa9

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		PLT-1.1: Interface breakout Test
Cisco 8000E		PLT-1.1: Interface breakout Test
Cisco XRd		PLT-1.1: Interface breakout Test
Juniper ncPTX		PLT-1.1: Interface breakout Test
Nokia SR Linux		PLT-1.1: Interface breakout Test
Openconfig Lemming		PLT-1.1: Interface breakout Test

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		PLT-1.1: Interface breakout Test
Cisco 8808		PLT-1.1: Interface breakout Test
Juniper PTX10008		PLT-1.1: Interface breakout Test
Nokia 7250 IXR-10e		PLT-1.1: Interface breakout Test

Help

[dplore]

/gcbrun

[coveralls]

Pull Request Test Coverage Report for Build 12434843545

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 55.268%

---

Totals
Change from base Build 12422942759:	0.0%
Covered Lines:	1983
Relevant Lines:	3588

---

💛 - Coveralls

[dplore]

/fptest cisco-8808

[amrindrr]

Please fix static analysis errors before submitting

[amrindrr]

Ideally there should be singe _test.go file in a folder. I see this file has most of helper functions and doesn't include any Test function. I would suggest to move the helper functions inside /internal. For example functions related to platform probably could go into a library that's already started at: internal/components/components.go. Similarly different location for IP address incrementing function (inside /internal)

[mastarkey]

can we merge this I will raise a git issue to make those changes. This item has been here for almost a year and there is endless back and forth on this. At a minimum i would like to merge it just to stop having to make changes to the devations.go file which are constantly eating my time to resolve it only for someone to make some other suggestions on the case. so ideally can we merge this and raise an git issue on those changes

[amrindrr]

Sounds good. You can send separate PR to make file and helper function changes.

[dplore]

Yes, making refactoring the helpers can be in a follow up PR.
issue tracking: #3663

[mastarkey]

Hi @dplore can you look into approving this? its waiting on your approval.

[dplore]

/fptest cisco-8808

[amrindrr]

/fptest

[dplore]

@mastarkey hi, this is ready to merge given the follow up issue, except there are still 7 static checks failing. Can you please resole those and I'll approve and merge.

@amrindrr will iterate with you regarding the CLI used for determining breakout capability since there are not currently any OC paths for querying breakout capabilities

[dplore]

This looks good, except there are still several style/static analysis issues. Can you please resolve?

You can view them all here:
https://github.com/openconfig/featureprofiles/pull/3648/files