Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹: Clean up CODEOWNERS to reflect approvers. #3655

Merged
merged 2 commits into from
Dec 17, 2024
Merged

🧹: Clean up CODEOWNERS to reflect approvers. #3655

merged 2 commits into from
Dec 17, 2024

Conversation

robshakir
Copy link
Contributor 

commit e7aa0b4e6e5baf2b3312d92ad733e0b879b0b452
Author: Rob Shakir <[email protected]>
Date:   Tue Dec 17 12:06:46 2024 -0800

    Add @morrowc as a security codeowner.
    
     * (M) .github/CODEOWNERS
      - annoint @morrowc as a security codeowner.

commit ea2f92bd745fb9170267a5c52c269069309f8d7e
Author: Rob Shakir <[email protected]>
Date:   Tue Dec 17 12:04:39 2024 -0800

    🧹: housekeeping to ensure well-scoped CODEOWNERS.
    
     * (M) .github/CODEOWNERS
      - `s/featureprofiles-maintainers/featureprofiles-approvers/g` to
        have a clear group of folks that are the default CODEOWNERS.

@robshakir
🧹: housekeeping to ensure well-scoped CODEOWNERS.
ea2f92b 
 * (M) .github/CODEOWNERS
  - `s/featureprofiles-maintainers/featureprofiles-approvers/g` to
    have a clear group of folks that are the default CODEOWNERS.
@robshakir
Add @morrowc as a security codeowner.
e7aa0b4 
 * (M) .github/CODEOWNERS
  - annoint @morrowc as a security codeowner.
@robshakir robshakir requested a review from a team as a code owner December 17, 2024 20:08
@OpenConfigBot
Copy link

Pull Request Functional Test Report for #3655 / e7aa0b4

No tests identified for validation.

Help

@robshakir robshakir changed the title 🧹: Clean up CODEOWNERS to reflect approvers. 🧹: Clean up CODEOWNERS to reflect approvers. Dec 17, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12380586091

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%
Totals Coverage Status
Change from base Build 12380539169: 0.0%
Covered Lines: 1983
Relevant Lines: 3588
💛 - Coveralls

@dplore dplore merged commit f80fb73 into main Dec 17, 2024
16 checks passed
@dplore dplore deleted the robjs-codeowners branch December 18, 2024 06:44
@dplore dplore mentioned this pull request Dec 18, 2024
Merged
ampattan pushed a commit to nokia/featureprofiles that referenced this pull request Jan 17, 2025
@robshakir @ampattan
🧹: Clean up CODEOWNERS to reflect approvers. (openconfig#3655)
8a4a8b6 
* 🧹: housekeeping to ensure well-scoped CODEOWNERS.

 * (M) .github/CODEOWNERS
  - `s/featureprofiles-maintainers/featureprofiles-approvers/g` to
    have a clear group of folks that are the default CODEOWNERS.

* Add @morrowc as a security codeowner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplore dplore dplore approved these changes

@Ankur19 Ankur19 Ankur19 approved these changes

@self-maurya self-maurya Awaiting requested review from self-maurya

@rohit-rp rohit-rp Awaiting requested review from rohit-rp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robshakir @OpenConfigBot @coveralls @Ankur19 @dplore