Update sub test case to retain TTL=1 for incoming packets with TTL = 1 #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishnureddybadveli
requested review from
nflath,
nachikethas and
xw-g
as code owners
Pull Request Test Coverage Report for Build 12420450726Details
💛 - Coveralls |
dplore
reviewed
Dec 17, 2024
Addressing review comments.
dplore
approved these changes
Dec 19, 2024
|
@robshakir for 2nd review+approval since other gribi feature owners are unavailable or not connected to this use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sub test case to retain TTL=1 for incoming packets with TTL = 1