Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RT-1.26.3 static route preference #3664

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dplore
Copy link
Member

@dplore dplore commented Dec 19, 2024

The functionality in the README is not correct and the feature as stated is not required.

@OpenConfigBot
Copy link

OpenConfigBot commented Dec 19, 2024

Pull Request Functional Test Report for #3664 / ed9ef93

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
RT-1.26: Basic static route support
d62f8549 Log
Cisco 8000E status
RT-1.26: Basic static route support
23f40d6e Log
Cisco XRd status
RT-1.26: Basic static route support
1275d1f9 Log
Juniper ncPTX status
RT-1.26: Basic static route support
50c11f4c Log
Nokia SR Linux status
RT-1.26: Basic static route support
21b23622 Log
Openconfig Lemming status
RT-1.26: Basic static route support
e7e7bcfa Log

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
RT-1.26: Basic static route support
Cisco 8808 status
RT-1.26: Basic static route support
Juniper PTX10008 status
RT-1.26: Basic static route support
Nokia 7250 IXR-10e status
RT-1.26: Basic static route support

Help

@coveralls
Copy link

coveralls commented Dec 19, 2024

Pull Request Test Coverage Report for Build 12424046725

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12422942759: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@Swetha-haridasula
Copy link
Contributor

Why is the functionality not correct? Could you eleborate?
The feature is required as we utilize preference/AD for HA of management links

@dplore
Copy link
Member Author

dplore commented Dec 27, 2024

This is an incorrect use of preference. Preference is defined as selecting the desired route between different protocols. (for example: static vs. BGP vs. ISIS). Preference is not defined (in OC) as selection criteria between two routes in the same protocol.

Reference:
https://github.com/openconfig/public/blob/850e572ae45613d8f29f25ac8d87a4d51db2f8fc/release/models/local-routing/openconfig-local-routing.yang#L174-L185

@Swetha-haridasula
Copy link
Contributor

@dplore In case management HA CPN topology, we have default route being received by BGP and we have a backup static default route as well. The design is to use the iBGP default route as more preferred route over the static route. Hence the AD of static route is modified. Please refer to b/373412048 for recent CPN HA design change as well as 'https://docs.google.com/document/d/1l9KsbhgzLb3lXgxsledrqktYIam5TBoMqvy5em3m5hU/edit?tab=t.0#heading=h.jzghbleb96qw ' where option#1 was finalized.

@dplore
Copy link
Member Author

dplore commented Dec 27, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants