Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System-1: System testing : Added Deviation #3667

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mnp-juniper
Copy link

Resolved conflicts for #3416

@mnp-juniper mnp-juniper requested a review from a team December 20, 2024 10:48
Copy link

google-cla bot commented Dec 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@OpenConfigBot
Copy link

OpenConfigBot commented Dec 20, 2024

Pull Request Functional Test Report for #3667 / 43d6960

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
System-1: System testing
Cisco 8000E status
System-1: System testing
Cisco XRd status
System-1: System testing
Juniper ncPTX status
System-1: System testing
Nokia SR Linux status
System-1: System testing
Openconfig Lemming status
System-1: System testing

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
System-1: System testing
Cisco 8808 status
System-1: System testing
Juniper PTX10008 status
System-1: System testing
Nokia 7250 IXR-10e status
System-1: System testing

Help

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12430070467

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 55.268%

Totals Coverage Status
Change from base Build 12419317171: 0.0%
Covered Lines: 1983
Relevant Lines: 3588

💛 - Coveralls

@Swetha-haridasula
Copy link
Contributor

needs changes to align with other vendors and general use usecase.

  1. Juniper must first add new deviation GNMIGetOnRootUnsupported as in PR#2605
  2. Then add 3 Subtests. First for state, second for config, 3rd for operational
  3. For first subtest add another deviation GNMIGetOnStateUnsupported and add the alternative for it which is using gnmi subscribe I believe
  4. For second subtest deviation is not needed for Juniper
  5. For 3rd subtest add a deviation and skip it if there is no alternative available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants