Added print-request and dry-run support for subscribe #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimra
requested changes
Jul 15, 2024
Comment on lines
+227
to
+229
| if a.Config.LocalFlags.SubscribeDryRun { | ||
| os.Exit(0) | ||
| } |
There was a problem hiding this comment.
In the case the subscribe command is running against multiple targets, the os.Exit(0) will stop the process before all the subscribe requests are printed.
There was a problem hiding this comment.
After the return statement, the program is left waiting for something. I was not able to figure out where it waits. Can you help me out here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added print-request and dry-run support for subscribe