Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RPC and other start parameters. #200

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Conversation

alshabib
Copy link
Contributor

@alshabib alshabib commented Jun 4, 2024

This commit adds an UpdateContainer RPC as well as some parameters for starting containers.

@coveralls
Copy link

coveralls commented Jun 4, 2024

Pull Request Test Coverage Report for Build 9732590323

Details

  • 0 of 943 (0.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 1.142%

Changes Missing Coverage Covered Lines Changed/Added Lines %
containerz/containerz_grpc.pb.go 0 86 0.0%
containerz/containerz.pb.go 0 857 0.0%
Files with Coverage Reduction New Missed Lines %
containerz/containerz.pb.go 6 0.0%
Totals Coverage Status
Change from base Build 9179326367: -0.06%
Covered Lines: 166
Relevant Lines: 14537

💛 - Coveralls

containerz/containerz.proto Show resolved Hide resolved
containerz/containerz.proto Outdated Show resolved Hide resolved
containerz/containerz.proto Outdated Show resolved Hide resolved
@alshabib alshabib force-pushed the update branch 2 times, most recently from bbac37e to 41bbdda Compare June 7, 2024 08:08
Copy link
Contributor

@robshakir robshakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a number of clarification questions for the changes here.

Do we propose to support these changes in the reference implementation?

containerz/containerz.proto Outdated Show resolved Hide resolved
containerz/containerz.proto Outdated Show resolved Hide resolved
containerz/containerz.proto Outdated Show resolved Hide resolved
containerz/containerz.proto Outdated Show resolved Hide resolved
containerz/containerz.proto Show resolved Hide resolved
containerz/containerz.proto Show resolved Hide resolved
containerz/containerz.proto Show resolved Hide resolved
containerz/containerz.proto Show resolved Hide resolved
containerz/containerz.proto Show resolved Hide resolved
containerz/containerz.proto Show resolved Hide resolved
@alshabib
Copy link
Contributor Author

Added a number of clarification questions for the changes here.

Do we propose to support these changes in the reference implementation?

Yes we will implement this changes in the reference implementation.

@alshabib alshabib force-pushed the update branch 2 times, most recently from d9e3c6c to 432e01c Compare June 19, 2024 11:21
This commit adds an UpdateContainer RPC as well as some
parameters for starting containers.
containerz/containerz.proto Outdated Show resolved Hide resolved
@robshakir robshakir merged commit bae5fb4 into openconfig:main Jul 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants