gnsi/pathz: clarify rotation behaviour for ongoing gNMI subscriptions #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianneville
changed the title
ncorran
reviewed
Dec 18, 2023
marcushines
approved these changes
Dec 19, 2023
brianneville
force-pushed
the
gnsi-pathz-subscriptions
branch
from
b92fde0 to
a27f5ea
Compare
ncorran
suggested changes
Jan 24, 2024
|
I think at this point to resolve the issue we should look at simply dropping the connections on rotation and just forcing the new policy to be applied (this really only applies to streaming methods) |
brianneville
force-pushed
the
gnsi-pathz-subscriptions
branch
from
a27f5ea to
bc5f8a8
Compare
Sounds fine - I've update the PR so that this approach is referenced in the index.md, please take a look @marcushines @ncorran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index.md is updated with a section covering the expected behaviour for ongoing subscriptions when a server
experiences a pathz policy change.
This commit also updates the pathz.UploadResponse value so that
it contains information about ongoing subscriptions and whether
they would experience different behaviour under the incoming policy. .pb.go files were regenerated.