gnsi/certz: rename certz counters #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename the access-accepts/access-rejects counters and timestamps to connection-accepts/connection-rejects This is more indicative of the fact that these counters are not really controlling access (which would be authorization/authz) but rather just whether a connection can be established based on the SSL profile
marcushines
approved these changes
Feb 13, 2024
Merged
brianneville
added a commit
to brianneville/oc-public
that referenced
this pull request
Mar 5, 2024
The certz yang file was updated since the PR to move from openconfig/gnsi to openconfig/public, and this updated version of certz had not been included in the PR. see the changes to gnsi-certz.yang at: openconfig/gnsi#156 This commit also sets the container name for the certz counters to be just "counters" to be backward-compatible with the existing gnsi-certz.yang. The module name/prefix already mark these counters as certz-related, so we don't need to duplicate this information in the container name too.
dplore
pushed a commit
to openconfig/public
that referenced
this pull request
Mar 6, 2024
* (M) release/models/gnsi/openconfig-gnsi-certz.yang Align oc paths for gnsi with latest certz version. See the changes to gnsi-certz.yang at: openconfig/gnsi#156 This commit also sets the container name for the certz counters to be just "counters" to be backward-compatible with the existing gnsi-certz.yang. The module name/prefix already mark these counters as certz-related, so we don't need to duplicate this information in the container name too.
romeyod
pushed a commit
to romeyod/aftNextHop
that referenced
this pull request
Sep 19, 2024
* (M) release/models/gnsi/openconfig-gnsi-certz.yang Align oc paths for gnsi with latest certz version. See the changes to gnsi-certz.yang at: openconfig/gnsi#156 This commit also sets the container name for the certz counters to be just "counters" to be backward-compatible with the existing gnsi-certz.yang. The module name/prefix already mark these counters as certz-related, so we don't need to duplicate this information in the container name too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename the access-accepts/access-rejects
counters and timestamps to
connection-accepts/connection-rejects
This is more indicative of the fact that these
counters are not really controlling access
(which would be authorization/authz) but rather just whether a connection can be established
based on the SSL profile