Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify multiplexing profile operations is not allowed in Certz.Rotate #201

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Clarify multiplexing profile operations is not allowed in Certz.Rotate #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion certz/certz.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,12 @@ service Certz {
// Step 4: Final commit.
// Client ---> FinalizeRequest ----> Target
//
// A `Rotate` RPC has a context of a single `profile` -- it is not
// permitted to multiplex operations for multiple profiles within the
// context of the same RPC (i.e., requesting a CSR for profile A, followed
// by requesting a CSR for profile B using the same `Rotate` RPC). In the
// case that such multiplexing is observed, the server should respond with
// an error specifying `InvalidArgument` as the status code.
rpc Rotate(stream RotateCertificateRequest)
returns (stream RotateCertificateResponse);

Expand Down Expand Up @@ -287,7 +293,7 @@ message RotateCertificateRequest {
// An identifier for the specific SSL profile (collection of
// certs/bundles/CRLs) which is being rotated through this stream.
// Leaving this field blank will result in an InvalidArgument error
// being returned to the client
// being returned to the client.
string ssl_profile_id = 2;

// Request Messages.
Expand Down
Loading