Add credentialz endpoints to manage system role accounts. #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LimeHat
reviewed
Oct 29, 2024
| @@ -224,6 +224,16 @@ service Credentialz { | |||
| // Get the current public keys from the host. Each configured key will be | |||
| // returned in the provided list. | |||
| rpc GetPublicKeys(GetPublicKeysRequest) returns (GetPublicKeysResponse); | |||
|
|
|||
| // Add a system role account. | |||
There was a problem hiding this comment.
Would be good to add a strict definition what a "system role account" is.
OpenConfig has SYSTEM_ROLE_ADMIN https://github.com/openconfig/public/blob/db78d44e93a97cef4db27f82bba3fba454e907a5/release/models/system/openconfig-aaa-types.yang#L77-L84, but I have a feeling that you mean something else in this context.
There was a problem hiding this comment.
Is it the case, avanpo, that you mean here:
"Add an account to the NOS, but not to the underlying unix system."
This maybe an operator account:
operator - robot/user responsible for interface up/down/troubleshooting
or an administrative account:
god - the user with all power/privilege on the device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there is no way to manage system role accounts via openconfig today, meaning it's necessary to know about the NOS or underlying OS in order to get that done.