Issue210: Update / Improve comment for 'AccountCredentials'. #211
Conversation
Update the docuemntation for AccountCredential to make it clear what the parts of the proto message mean, with respect to a normal openssh format ssh public key.
|
I'd assign this to @LimeHat but apparently I can't do that? |
|
I'd also try to assign this to @melzhan but I can't do that either? how does review / assignment / review even work here? |
I created a team: https://github.com/orgs/openconfig/teams/gnsi-contributors/members There is a maintainers team (https://github.com/orgs/openconfig/teams/gnsi-maintainers) which has write access. |
There was a problem hiding this comment.
If the non-zero key_type field presence is mandatory, please indicate that in the comment.
In addition, if you want to document the message as a whole, note that the mapping between the enum key_type and the openssh key type is N:1 instead of 1:1 (for whatever reason we have three different RSA key types; all of which will be mapped to ssh-rsa in the openssh authorized_keys file format).
|
It looks like I can't approve this and it needs approval from Rob or Marcus |
Update the docuemntation for AccountCredential to make it clear what the parts of the proto message mean, with respect to a normal openssh format ssh public key.