Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test build - this may get deleted, or include fixes to the github/workflows/bazel.yaml file eventually? #216

Merged
merged 11 commits into from
Jan 6, 2025

Conversation

morrowc
Copy link
Contributor

@morrowc morrowc commented Jan 5, 2025

Making a PR in order to trigger an actions run.

Add some clarification that SSL Profiles maybe used for:
  * client services (services on a system which initiate connections)
  * server services (services on a system which receive connections)
  * both (clients and servers)
Cleanup a bit of the README content, mostly
language fixes seen upon re-reading the readings.
Make this BUILD target look like a working BUILD target (credentialz)
A change may be necessary to the BUILD or githubactions/workflows
to accomodate new ubuntu images.
@morrowc
Copy link
Contributor Author

morrowc commented Jan 5, 2025

This fails to build, with just a comment change in the certz/BUILD.bazel:

INFO: Found 64 targets...
[0 / 1,502] [Prepa] BazelWorkspaceStatusAction stable-status.txt
[911 / 2,069] [Prepa] Generating Descriptor Set proto_library //certz:certz_proto
[1,891 / 2,157] [Scann] Compiling credentialz/credentialz_cc_proto_pb/github.com/openconfig/gnsi/credentialz/credentialz.pb.cc
[2,130 / 2,157] Compiling credentialz/credentialz_cc_proto_pb/github.com/openconfig/gnsi/credentialz/credentialz.pb.cc; 1s processwrapper-sandbox ... (4 actions, 3 running)
ERROR: /home/runner/work/gnsi/gnsi/authz/BUILD.bazel:[20](https://github.com/openconfig/gnsi/actions/runs/12624024101/job/35173693180#step:5:21):17: Compiling authz/authz_cc_proto_pb/github.com/openconfig/gnsi/authz/authz.pb.cc failed: undeclared inclusion(s) in rule '//authz:authz_cc_proto':
this rule is missing dependency declarations for the following files included by 'authz/authz_cc_proto_pb/github.com/openconfig/gnsi/authz/authz.pb.cc':
  '/usr/lib/gcc/x86_64-linux-gnu/13/include/stddef.h'
  '/usr/lib/gcc/x86_64-linux-gnu/13/include/stdarg.h'
  '/usr/lib/gcc/x86_64-linux-gnu/13/include/stdint.h'
  '/usr/lib/gcc/x86_64-linux-gnu/13/include/limits.h'
  '/usr/lib/gcc/x86_64-linux-gnu/13/include/syslimits.h'
[2,136 / 2,157] Compiling credentialz/credentialz_cc_proto_pb/github.com/openconfig/gnsi/credentialz/credentialz.pb.cc; 2s processwrapper-sandbox ... (3 actions, 2 running)
INFO: Elapsed time: 15.[23](https://github.com/openconfig/gnsi/actions/runs/12624024101/job/35173693180#step:5:24)1s, Critical Path: 2.38s
INFO: 48 processes: 12 internal, 36 processwrapper-sandbox.
FAILED: Build did NOT complete successfully

This is also failing in the previous PR(#215), so perhaps this this here, merge back and go forward.

@morrowc
Copy link
Contributor Author

morrowc commented Jan 6, 2025

'internet advice' seems to say that blowing away the cache and re-building makes this problem go away.

It LOOKS like the problem is 'bazel isn't telling gcc where the std lib headers are"
which seems looney, but...

@morrowc
Copy link
Contributor Author

morrowc commented Jan 6, 2025

Oh, with the cache enabled the build fails still.
For now, disable the cache until someone else with more time/skillz can fix this properly.

@morrowc morrowc requested a review from marcushines January 6, 2025 00:59
@morrowc
Copy link
Contributor Author

morrowc commented Jan 6, 2025

and ideally @marcushines to either ack or point at proper process to fix this :)

@morrowc
Copy link
Contributor Author

morrowc commented Jan 6, 2025

argh, also some linter failures :( grumble.

@morrowc
Copy link
Contributor Author

morrowc commented Jan 6, 2025

Ok, converted the workflow (bazel.yaml) to use the bazelisk pre-built/offered workflow instead of some multi-line yaml thing that linter got mad about.

Linter passes now.
Bzael build appears to work (minus the cache!).

@marcushines marcushines merged commit f2a13cb into main Jan 6, 2025
9 checks passed
@marcushines marcushines deleted the testBuild branch January 6, 2025 14:21
morrowc added a commit that referenced this pull request Jan 22, 2025
…kflows/bazel.yaml file eventually? (#216)

* Issue202: Add clarification on usage of ssl profiles.

Add some clarification that SSL Profiles maybe used for:
  * client services (services on a system which initiate connections)
  * server services (services on a system which receive connections)
  * both (clients and servers)

* Documentation Cleanup.

Cleanup a bit of the README content, mostly
language fixes seen upon re-reading the readings.

* Address comment.

* Attempting to fix a broken bazel build in github-actions.

Make this BUILD target look like a working BUILD target (credentialz)

* Add to the BUILD fixing?

* Testing github-actions BUILD.

A change may be necessary to the BUILD or githubactions/workflows
to accomodate new ubuntu images.

* Remove the bazel cache, clearing it MAY resolve build errors.

* Remove comment from BUILD.

* Remove BUILD changes.

* Remove commented section.

* Attempt to use an already available bazel/bazelisk.

Use a supported (from lemming's use as well) version
of workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants