Skip to content

Commit

Permalink
test fix
Browse files Browse the repository at this point in the history
  • Loading branch information
DanG100 committed Jul 11, 2024
1 parent 6236212 commit 48f7804
Showing 1 changed file with 19 additions and 14 deletions.
33 changes: 19 additions & 14 deletions dataplane/saiserver/acl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ func TestCreateAclEntry(t *testing.T) {
EntryDesc: &fwdpb.EntryDesc{
Entry: &fwdpb.EntryDesc_Flow{
Flow: &fwdpb.FlowEntryDesc{
Id: 1,
Id: 2,
Fields: []*fwdpb.PacketFieldMaskedBytes{{
FieldId: &fwdpb.PacketFieldId{Field: &fwdpb.PacketField{FieldNum: fwdpb.PacketFieldNum_PACKET_FIELD_NUM_IP_ADDR_DST}},
Bytes: []byte{127, 0, 0, 1},
Expand Down Expand Up @@ -207,7 +207,7 @@ func TestCreateAclEntry(t *testing.T) {
EntryDesc: &fwdpb.EntryDesc{
Entry: &fwdpb.EntryDesc_Flow{
Flow: &fwdpb.FlowEntryDesc{
Id: 1,
Id: 2,
Fields: []*fwdpb.PacketFieldMaskedBytes{{
FieldId: &fwdpb.PacketFieldId{Field: &fwdpb.PacketField{FieldNum: fwdpb.PacketFieldNum_PACKET_FIELD_NUM_IP_ADDR_DST}},
Bytes: []byte{127, 0, 0, 1},
Expand Down Expand Up @@ -256,7 +256,7 @@ func TestCreateAclEntry(t *testing.T) {
EntryDesc: &fwdpb.EntryDesc{
Entry: &fwdpb.EntryDesc_Flow{
Flow: &fwdpb.FlowEntryDesc{
Id: 1,
Id: 2,
Fields: []*fwdpb.PacketFieldMaskedBytes{{
FieldId: &fwdpb.PacketFieldId{Field: &fwdpb.PacketField{FieldNum: fwdpb.PacketFieldNum_PACKET_FIELD_NUM_IP_ADDR_DST}},
Bytes: []byte{127, 0, 0, 1},
Expand Down Expand Up @@ -305,7 +305,7 @@ func TestCreateAclEntry(t *testing.T) {
EntryDesc: &fwdpb.EntryDesc{
Entry: &fwdpb.EntryDesc_Flow{
Flow: &fwdpb.FlowEntryDesc{
Id: 1,
Id: 2,
Fields: []*fwdpb.PacketFieldMaskedBytes{{
FieldId: &fwdpb.PacketFieldId{Field: &fwdpb.PacketField{FieldNum: fwdpb.PacketFieldNum_PACKET_FIELD_NUM_IP_ADDR_DST}},
Bytes: []byte{127, 0, 0, 1},
Expand Down Expand Up @@ -342,7 +342,7 @@ func TestCreateAclEntry(t *testing.T) {
EntryDesc: &fwdpb.EntryDesc{
Entry: &fwdpb.EntryDesc_Flow{
Flow: &fwdpb.FlowEntryDesc{
Id: 1,
Id: 2,
Fields: []*fwdpb.PacketFieldMaskedBytes{{
FieldId: &fwdpb.PacketFieldId{Field: &fwdpb.PacketField{FieldNum: fwdpb.PacketFieldNum_PACKET_FIELD_NUM_IP_ADDR_DST}},
Bytes: []byte{127, 0, 0, 1},
Expand Down Expand Up @@ -379,7 +379,7 @@ func TestCreateAclEntry(t *testing.T) {
EntryDesc: &fwdpb.EntryDesc{
Entry: &fwdpb.EntryDesc_Flow{
Flow: &fwdpb.FlowEntryDesc{
Id: 1,
Id: 2,
Fields: []*fwdpb.PacketFieldMaskedBytes{{
FieldId: &fwdpb.PacketFieldId{Field: &fwdpb.PacketField{FieldNum: fwdpb.PacketFieldNum_PACKET_FIELD_NUM_IP_ADDR_DST}},
Bytes: []byte{127, 0, 0, 1},
Expand Down Expand Up @@ -407,6 +407,9 @@ func TestCreateAclEntry(t *testing.T) {
}
dplane.ctx.Objects.Insert(&fwdobject.Base{}, &fwdpb.ObjectId{Id: "1"})
c, a, stopFn := newTestACL(t, dplane)
a.mgr.StoreAttributes(a.mgr.NextID(), &saipb.SwitchAttribute{
CpuPort: proto.Uint64(10),
})
a.tableToLocation[1] = tableLocation{
groupID: "1",
bank: 0,
Expand Down Expand Up @@ -435,21 +438,21 @@ func TestRemoveAclEntry(t *testing.T) {
}{{
desc: "not found",
req: &saipb.RemoveAclEntryRequest{
Oid: 2,
Oid: 3,
},
wantErr: "FailedPrecondition",
}, {
desc: "success",
req: &saipb.RemoveAclEntryRequest{
Oid: 1,
Oid: 2,
},
want: &fwdpb.TableEntryRemoveRequest{
ContextId: &fwdpb.ContextId{Id: "foo"},
TableId: &fwdpb.TableId{ObjectId: &fwdpb.ObjectId{Id: "1"}},
TableId: &fwdpb.TableId{ObjectId: &fwdpb.ObjectId{Id: "2"}},
EntryDesc: &fwdpb.EntryDesc{
Entry: &fwdpb.EntryDesc_Flow{
Flow: &fwdpb.FlowEntryDesc{
Id: 1,
Id: 2,
Fields: []*fwdpb.PacketFieldMaskedBytes{{
FieldId: &fwdpb.PacketFieldId{Field: &fwdpb.PacketField{FieldNum: fwdpb.PacketFieldNum_PACKET_FIELD_NUM_IP_ADDR_DST}},
Bytes: []byte{127, 0, 0, 1},
Expand All @@ -463,15 +466,17 @@ func TestRemoveAclEntry(t *testing.T) {
for _, tt := range tests {
t.Run(tt.desc, func(t *testing.T) {
dplane := &fakeSwitchDataplane{}

c, a, stopFn := newTestACL(t, dplane)
a.mgr.StoreAttributes(a.mgr.NextID(), &saipb.SwitchAttribute{
CpuPort: proto.Uint64(10),
})
defer stopFn()
a.tableToLocation[1] = tableLocation{
groupID: "1",
a.tableToLocation[2] = tableLocation{
groupID: "2",
bank: 0,
}
_, err := c.CreateAclEntry(context.TODO(), &saipb.CreateAclEntryRequest{
TableId: proto.Uint64(1),
TableId: proto.Uint64(2),
FieldDstIp: &saipb.AclFieldData{
Data: &saipb.AclFieldData_DataIp{
DataIp: []byte{127, 0, 0, 1},
Expand Down

0 comments on commit 48f7804

Please sign in to comment.