Send request to set oper status state for host interfaces.

openconfig · Jan 10, 2025 · ed62a5c · ed62a5c
1 parent 2eef855
commit ed62a5c
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 3 deletions.
diff --git a/dataplane/saiserver/hostif.go b/dataplane/saiserver/hostif.go
@@ -91,6 +91,17 @@ func (hostif *hostif) CreateHostif(ctx context.Context, req *saipb.CreateHostifR
 		PortId:        id,
 	}
 
+	oper_status := pktiopb.PortOperation_PORT_OPERATION_SET_DOWN
+
+	if req.GetOperStatus() {
+		oper_status = pktiopb.PortOperation_PORT_OPERATION_SET_UP
+	}
+
+	operReq := &pktiopb.HostPortControlMessage{
+		PortId: id,
+		Op:     oper_status,
+	}
+
 	switch req.GetType() {
 	case saipb.HostifType_HOSTIF_TYPE_GENETLINK:
 		name := string(req.GetName()) // The name can be genl_packet_q0, but the netlink family is gen_packet.
@@ -157,6 +168,9 @@ func (hostif *hostif) CreateHostif(ctx context.Context, req *saipb.CreateHostifR
 	if err := hostif.remotePortReq(ctlReq); err != nil {
 		return nil, err
 	}
+	if err := hostif.remotePortReq(operReq); err != nil {
+		return nil, err
+	}
 
 	attr := &saipb.HostifAttribute{
 		OperStatus: proto.Bool(true),

diff --git a/dataplane/saiserver/hostif_test.go b/dataplane/saiserver/hostif_test.go
@@ -35,6 +35,7 @@ import (
 	fwdpb "github.com/openconfig/lemming/proto/forwarding"
 )
 
+
 func TestCreateHostif(t *testing.T) {
 	tests := []struct {
 		desc     string
@@ -98,7 +99,7 @@ func TestCreateHostif(t *testing.T) {
 
 			ctx, cancel := context.WithCancel(context.Background())
 			defer cancel()
-			msgCh := make(chan *pktiopb.HostPortControlMessage, 1)
+			msgCh := make(chan *pktiopb.HostPortControlMessage, 2)
 			pc, err := c.HostPortControl(ctx)
 			if err != nil {
 				t.Fatal(err)
@@ -107,7 +108,7 @@ func TestCreateHostif(t *testing.T) {
 				t.Fatal(err)
 			}
 			time.Sleep(time.Millisecond)
-			go func() {
+			processRequest := func() {
 				msg, _ := pc.Recv()
 				msgCh <- msg
 				pc.Send(&pktiopb.HostPortControlRequest{
@@ -118,7 +119,10 @@ func TestCreateHostif(t *testing.T) {
 						},
 					},
 				})
-			}()
+			}
+
+			go processRequest()
+			go processRequest()
 
 			defer stopFn()
 			got, gotErr := c.CreateHostif(context.TODO(), tt.req)
@@ -131,7 +135,10 @@ func TestCreateHostif(t *testing.T) {
 			if d := cmp.Diff(got, tt.want, protocmp.Transform()); d != "" {
 				t.Errorf("CreateHostif() failed: diff(-got,+want)\n:%s", d)
 			}
+
 			_ = <-msgCh
+			_ = <-msgCh
+
 			attr := &saipb.HostifAttribute{}
 			if err := mgr.PopulateAllAttributes("3", attr); err != nil {
 				t.Fatal(err)