Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lemming dataplane gnmi use the SAI API #334

Merged
merged 8 commits into from
Nov 30, 2023
Merged

Make lemming dataplane gnmi use the SAI API #334

merged 8 commits into from
Nov 30, 2023

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Nov 29, 2023

sorry about the size of this, it was smallest i could do get to the tests passing

  • summary of changes: simplified the dpb.Route message and changed sysrib to use it
  • modified the reconcilers package to call the sai API.

still a little more work to remove engine entirely and change the directory structure a bit

@DanG100 DanG100 requested review from wenovus and removed request for wenovus November 29, 2023 21:57
Copy link

github-actions bot commented Nov 30, 2023

Pull Request Test Coverage Report for Build 7053217846

  • 112 of 974 (11.5%) changed or added relevant lines in 15 files are covered.
  • 90 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.002%) to 2.431%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/standalone/saiserver/saiserver.go 0 1 0.0%
dataplane/forwarding/protocol/metadata/metadata.go 0 2 0.0%
dataplane/standalone/saiserver/switch.go 18 20 90.0%
dataplane/standalone/saiserver/acl.go 6 9 66.67%
dataplane/internal/engine/engine.go 0 4 0.0%
dataplane/reconcilers_linux.go 0 7 0.0%
dataplane/internal/kernel/kernel.go 0 8 0.0%
dataplane/standalone/saiserver/hostif.go 22 30 73.33%
dataplane/standalone/saiserver/routing.go 4 37 10.81%
dataplane/server.go 0 44 0.0%
Files with Coverage Reduction New Missed Lines %
dataplane/internal/engine/engine.go 1 0.0%
dataplane/reconcilers_linux.go 1 0.0%
dataplane/standalone/saiserver/acl.go 1 64.35%
dataplane/standalone/saiserver/routing.go 2 70.62%
gnmi/oc/structs-3.go 40 0.05%
bgp/gobgp.go 45 41.58%
Totals Coverage Status
Change from base Build 6897489228: -0.002%
Covered Lines: 15769
Relevant Lines: 648772

💛 - Coveralls

dataplane/reconcilers/routes.go Outdated Show resolved Hide resolved
dataplane/reconcilers/routes.go Outdated Show resolved Hide resolved
dataplane/reconcilers/interface.go Outdated Show resolved Hide resolved
dataplane/config/config.go Show resolved Hide resolved
dataplane/standalone/saiserver/hostif.go Show resolved Hide resolved
sysrib/server.go Outdated Show resolved Hide resolved
dataplane/reconcilers/routes.go Outdated Show resolved Hide resolved
@DanG100 DanG100 requested a review from wenovus November 30, 2023 23:21
@DanG100
Copy link
Collaborator Author

DanG100 commented Nov 30, 2023

i haven't seen any flakiness with the tests now.

@DanG100 DanG100 merged commit b22a398 into main Nov 30, 2023
8 checks passed
@DanG100 DanG100 deleted the lemming-sai branch November 30, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants