Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete engine and flatten dataplane directory #337

Merged
merged 4 commits into from
Dec 5, 2023
Merged

Delete engine and flatten dataplane directory #337

merged 4 commits into from
Dec 5, 2023

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Dec 5, 2023 •
edited
Loading

  • Moved dataplane/standalone/proto -> dataplane/proto
  • Move dataplane/standalone/saiserver -> dataplane/saiserver
  • Moved remaining code in engine package to saiserver

@DanG100 DanG100 requested a review from wenovus December 5, 2023 19:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7107228962

  • 99 of 177 (55.93%) changed or added relevant lines in 9 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 2.442%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/dplanerc/routes.go 0 1 0.0%
dataplane/saiserver/hostif.go 1 2 50.0%
dataplane/server.go 0 1 0.0%
dataplane/apigen/docparser/docparser.go 0 2 0.0%
dataplane/saiserver/routing.go 9 14 64.29%
dataplane/saiserver/switch.go 82 91 90.11%
dataplane/saiserver/saiserver.go 0 59 0.0%
Files with Coverage Reduction New Missed Lines %
bgp/gobgp.go 2 41.58%
Totals Coverage Status
Change from base Build 7090847915: 0.001%
Covered Lines: 15843
Relevant Lines: 648818
💛 - Coveralls

@DanG100 DanG100 merged commit d3339c7 into main Dec 5, 2023
8 checks passed
@DanG100 DanG100 deleted the dplane-doc branch December 5, 2023 23:02
@DanG100 DanG100 requested a review from wenovus December 5, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenovus wenovus Awaiting requested review from wenovus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @wenovus