Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation aggregate interface config #340

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Initial implementation aggregate interface config #340

merged 3 commits into from
Dec 12, 2023

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Dec 11, 2023

No description provided.

@DanG100 DanG100 requested a review from wenovus December 11, 2023 23:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7187517496

  • 2 of 184 (1.09%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.002%) to 2.441%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/switch.go 2 5 40.0%
dataplane/dplanerc/interface.go 0 179 0.0%
Files with Coverage Reduction New Missed Lines %
dataplane/dplanerc/interface.go 1 0.0%
gnmi/oc/enum.go 1 3.51%
bgp/gobgp.go 2 41.58%
gnmi/oc/structs-2.go 6 2.04%
Totals Coverage Status
Change from base Build 7131717385: -0.002%
Covered Lines: 15844
Relevant Lines: 648984
💛 - Coveralls

wenovus
wenovus approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@wenovus wenovus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

dataplane/saiserver/switch.go Outdated Show resolved Hide resolved
integration_tests/onedut_oneotg_tests/aggregate/aggregate_test.go Show resolved Hide resolved
@DanG100 DanG100 merged commit aec0db1 into main Dec 12, 2023
8 checks passed
@DanG100 DanG100 deleted the agg-intf branch December 12, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenovus wenovus wenovus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @wenovus