Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make packetio its own RPC service #390

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Make packetio its own RPC service #390

merged 3 commits into from
Mar 27, 2024

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Mar 27, 2024 •
edited
Loading

This makes the packetio stuff more generic, not tied to the forwarding protos

@DanG100 DanG100 requested a review from guoshiuan March 27, 2024 19:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8459096730

Details

  • 59 of 138 (42.75%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 2.7%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/forwarding/fwd.go 0 2 0.0%
dataplane/standalone/pkthandler/pktiohandler/pktiohandler.go 15 25 60.0%
dataplane/forwarding/fwdport/ports/cpu.go 0 12 0.0%
dataplane/saiserver/hostif.go 41 96 42.71%
Files with Coverage Reduction New Missed Lines %
dataplane/saiserver/hostif.go 2 45.69%
Totals Coverage Status
Change from base Build 8443106718: -0.002%
Covered Lines: 17582
Relevant Lines: 651107
💛 - Coveralls

guoshiuan
guoshiuan approved these changes Mar 27, 2024
View reviewed changes
@DanG100 DanG100 merged commit a861bd4 into main Mar 27, 2024
11 checks passed
@DanG100 DanG100 deleted the splitpacketio branch March 27, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshiuan guoshiuan guoshiuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @guoshiuan