Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support route-type BGP policy condition #411

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Support route-type BGP policy condition #411

merged 5 commits into from
Apr 30, 2024

Conversation

wenovus
Copy link
Contributor

@wenovus wenovus commented Apr 25, 2024

No description provided.

@wenovus wenovus requested a review from DanG100 April 25, 2024 18:27
Base automatically changed from rib-attr-as-segment to main April 26, 2024 16:37
Copy link

github-actions bot commented Apr 29, 2024

Pull Request Test Coverage Report for Build 8887275414

Details

  • 7 of 9 (77.78%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.001%) to 2.777%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bgp/ocgobgp.go 7 9 77.78%
Files with Coverage Reduction New Missed Lines %
sysrib/zapi.go 9 71.5%
Totals Coverage Status
Change from base Build 8883253541: 0.001%
Covered Lines: 18102
Relevant Lines: 651820

💛 - Coveralls

@wenovus
Copy link
Contributor Author

wenovus commented Apr 29, 2024

@DanG100 ping on this for review

@wenovus
Copy link
Contributor Author

wenovus commented Apr 30, 2024

I see some flakes going on in various tests (initially aggregate, and then also bgp_propagate). I want to observe a bit more before taking the time to debug.

@wenovus wenovus merged commit ab375a6 into main Apr 30, 2024
9 of 10 checks passed
@wenovus wenovus deleted the route-type-condition branch April 30, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants