Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial VLAN implementation #422

Merged
merged 20 commits into from
May 31, 2024
Merged

Initial VLAN implementation #422

merged 20 commits into from
May 31, 2024

Conversation

guoshiuan
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9311511771

Details

  • 156 of 189 (82.54%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 2.789%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/attrmgr/attrmgr.go 0 1 0.0%
dataplane/saiserver/switch.go 25 27 92.59%
dataplane/saiserver/ports.go 28 32 87.5%
dataplane/saiserver/routing.go 103 129 79.84%
Totals Coverage Status
Change from base Build 9216009660: 0.02%
Covered Lines: 18352
Relevant Lines: 657898
💛 - Coveralls

@guoshiuan guoshiuan requested a review from DanG100 May 28, 2024 16:12
DanG100
DanG100 reviewed May 28, 2024
View reviewed changes
DanG100
DanG100 approved these changes May 30, 2024
View reviewed changes
@guoshiuan guoshiuan merged commit a5f186c into main May 31, 2024
9 of 10 checks passed
@guoshiuan guoshiuan deleted the vlan branch May 31, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanG100 DanG100 DanG100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guoshiuan @DanG100