Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BGP prefix checking less flaky #423

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Make BGP prefix checking less flaky #423

merged 3 commits into from
Jun 6, 2024

Conversation

wenovus
Copy link
Contributor

@wenovus wenovus commented Jun 3, 2024

Currently it's failing because the Await check before the Get wait for any prefix rather than the prefix Get is looking for. This makes some of the checks fail intermittently when multiple prefixes are checked at the same time.

@wenovus wenovus requested a review from DanG100 June 3, 2024 22:28
Copy link

github-actions bot commented Jun 3, 2024

Pull Request Test Coverage Report for Build 9407860534

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 224 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.01%) to 2.802%

Files with Coverage Reduction New Missed Lines %
sysrib/zapi.go 9 71.5%
gnsi/pathz/pathz.go 13 84.03%
dataplane/saiserver/saiserver.go 29 61.86%
dataplane/saiserver/ports.go 84 82.77%
dataplane/saiserver/switch.go 89 86.33%
Totals Coverage Status
Change from base Build 9321685208: 0.01%
Covered Lines: 18441
Relevant Lines: 658042

💛 - Coveralls

@DanG100
Copy link
Collaborator

DanG100 commented Jun 4, 2024

this test is still failing on the presubmit

@wenovus
Copy link
Contributor Author

wenovus commented Jun 5, 2024

this test is still failing on the presubmit

Yeah I'm not sure what's going on, the test consistently passes locally. Will dig through the logs.

@DanG100 DanG100 merged commit 41b73cf into main Jun 6, 2024
9 of 10 checks passed
@DanG100 DanG100 deleted the fix-bgp-route-prop branch June 6, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants