Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for plumbing gRIBI server options through lemming. #451

Merged
merged 11 commits into from
Jul 16, 2024

Conversation

robshakir
Copy link
Contributor

 * (M) lemming.go
 * (M) gribi/gribi.go
  - for some behaviours, there is a need to change the underlying RIB functionality
    in the gRIBI server as a lemming is created. this change plumbs some options
    through to allow lemmings to be created using this method.

 * (M) lemming.go
 * (M) gribi/gribi.go
  - for some behaviours, there is a need to change the underlying RIB functionality
    in the gRIBI server as a lemming is created. this change plumbs some options
    through to allow lemmings to be created using this method.
@DanG100
Copy link
Collaborator

DanG100 commented Jul 12, 2024

Run make buildfile to update all the build files. probably need to include repositories.bzl as well

Copy link

github-actions bot commented Jul 12, 2024

Pull Request Test Coverage Report for Build 9963087255

Details

  • 6 of 10 (60.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 2.822%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lemming.go 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
dataplane/standalone/pkthandler/pktiohandler/pktiohandler.go 8 46.37%
Totals Coverage Status
Change from base Build 9915464407: 0.0%
Covered Lines: 18580
Relevant Lines: 658352

💛 - Coveralls

@robshakir
Copy link
Contributor Author

@DanG100 It looks like this "build and test" workflow is flaky. It passes locally w/KNE and periodically passes here. I don't think this is based on my change. Can you PTAL?

@robshakir robshakir requested a review from DanG100 July 16, 2024 15:42
lemming.go Outdated Show resolved Hide resolved
@DanG100
Copy link
Collaborator

DanG100 commented Jul 16, 2024

@DanG100 It looks like this "build and test" workflow is flaky. It passes locally w/KNE and periodically passes here. I don't think this is based on my change. Can you PTAL?

yeah, known issue on github runner, haven't had a chance to debug more

@robshakir
Copy link
Contributor Author

@DanG100 It looks like this "build and test" workflow is flaky. It passes locally w/KNE and periodically passes here. I don't think this is based on my change. Can you PTAL?

yeah, known issue on github runner, haven't had a chance to debug more

No problem, just wanted to validate -- backlog deflaking sgtm.

@robshakir robshakir merged commit 8502fd4 into main Jul 16, 2024
10 checks passed
@robshakir robshakir deleted the gribi-opts branch July 16, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants