Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protocol registry to the server. #470

Merged
merged 9 commits into from
Sep 4, 2024
Merged

Add protocol registry to the server. #470

merged 9 commits into from
Sep 4, 2024

Conversation

guoshiuan
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Sep 3, 2024

Pull Request Test Coverage Report for Build 10692504088

Details

  • 8 of 15 (53.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 2.879%

Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/forwarding/fwdport/ports/cpu.go 0 1 0.0%
dataplane/server.go 4 6 66.67%
dataplane/protocol/registry.go 4 8 50.0%
Totals Coverage Status
Change from base Build 10690260711: 0.002%
Covered Lines: 18968
Relevant Lines: 658911

💛 - Coveralls

@guoshiuan guoshiuan requested a review from DanG100 September 3, 2024 23:41
@DanG100
Copy link
Collaborator

DanG100 commented Sep 3, 2024

to fix the check. delete the build file in dataplane/protocol/ and run make buildfile it doesn't handle package renames gracefully, need to help it a bit

@guoshiuan guoshiuan merged commit 471a366 into main Sep 4, 2024
10 checks passed
@guoshiuan guoshiuan deleted the lldp branch September 4, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants