Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial tracing support for lucius #475

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Initial tracing support for lucius #475

merged 2 commits into from
Sep 12, 2024

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Sep 12, 2024

No description provided.

@DanG100 DanG100 requested a review from guoshiuan September 12, 2024 18:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10838285955

Details

  • 40 of 70 (57.14%) changed or added relevant lines in 2 files are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 2.871%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/switch.go 39 69 56.52%
Files with Coverage Reduction New Missed Lines %
sysrib/zapi.go 9 71.5%
Totals Coverage Status
Change from base Build 10835901753: 0.004%
Covered Lines: 18906
Relevant Lines: 658575
💛 - Coveralls

guoshiuan
guoshiuan approved these changes Sep 12, 2024
View reviewed changes
dataplane/standalone/lucius/lucius.go Outdated Show resolved Hide resolved
@DanG100 DanG100 merged commit 6627c8d into main Sep 12, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshiuan guoshiuan guoshiuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @guoshiuan