Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate saiserver to slog #477

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Migrate saiserver to slog #477

merged 2 commits into from
Sep 16, 2024

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Sep 16, 2024

No description provided.

@DanG100 DanG100 requested a review from guoshiuan September 16, 2024 18:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10890573215

Details

  • 9 of 26 (34.62%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 2.872%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/attrmgr/attrmgr.go 2 3 66.67%
dataplane/saiserver/ports.go 1 3 33.33%
dataplane/saiserver/switch.go 1 3 33.33%
dataplane/saiserver/saiserver.go 0 3 0.0%
dataplane/saiserver/routing.go 0 4 0.0%
dataplane/saiserver/hostif.go 5 10 50.0%
Totals Coverage Status
Change from base Build 10839728937: 0.002%
Covered Lines: 18913
Relevant Lines: 658575
💛 - Coveralls

@DanG100 DanG100 merged commit 0b67db7 into main Sep 16, 2024
10 checks passed
@DanG100 DanG100 deleted the slog branch September 16, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshiuan guoshiuan guoshiuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @guoshiuan