Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge proto and cc into common structs and split typeinfo file #499

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Merge proto and cc into common structs and split typeinfo file #499

merged 2 commits into from
Nov 18, 2024

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Nov 14, 2024

No description provided.

@DanG100 DanG100 requested a review from guoshiuan November 14, 2024 18:31
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 11843369526

Details

  • 108 of 176 (61.36%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 2.924%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/apigen/typeinfo/types.go 0 15 0.0%
dataplane/apigen/typeinfo/typeinfo.go 108 161 67.08%
Files with Coverage Reduction New Missed Lines %
dataplane/apigen/typeinfo/typeinfo.go 3 53.45%
Totals Coverage Status
Change from base Build 11826932174: 0.005%
Covered Lines: 19276
Relevant Lines: 659178
💛 - Coveralls

@DanG100 DanG100 merged commit 1384841 into main Nov 18, 2024
11 checks passed
@DanG100 DanG100 deleted the apigen-ref2 branch November 18, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshiuan guoshiuan guoshiuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @guoshiuan