-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ygnmi validator #93
Conversation
Pull Request Test Coverage Report for Build 6853610196
💛 - Coveralls |
Should we keep both ygot and ygnmi? What's the logic for replacing ygot? (It seems like they do different jobs, and may have different flags/ways of generating structs -- e.g., uncompressed vs. compressed). |
ygnmi generates a full set of ygot GoStructs with the recommended set of flags for ygot. This is because users of ygnmi in general need the full ygot functionality. However, there are small benefits to running ygot alongside ygnmi:
I didn't consider the last point here, and that seems to me like a good-enough reason to warrant the extra compute time, so let me add it as a second check. |
@robshakir @dplore PTAL. |
Tested @ openconfig/public#996 (see latest commits)