Fix sibling check for lists. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing check does not work if some of the nodes are augmented into the surrounding container. Removed old check and added new check. Added tests for both cases.
robshakir
approved these changes
Nov 3, 2023
This could be a pyang issue depending on the original intent. For some reason the augmented node only appears when validating the augmented nodes. They are validated at the end of |
…ported, we should fix this if necessary
dplore
approved these changes
Nov 3, 2023
|
Filed an issue in pyang: mbj4668/pyang#881 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing check does not work if some of the nodes are augmented into the surrounding container (see openconfig/public#991).
Tested at openconfig/public#993