Simplify sample pipeline input parameters #611
Conversation
|
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/611/head
git checkout -b pullrequest debdd18dd298287080d3e021568ccf76c6fce2e6
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-611"More instructions here on how to deploy and test a Data Science Pipelines Application. |
gmfrasca
force-pushed
the
simply-sample-pipeline
branch
from
debdd18 to
3a313a0
Compare
|
Change to PR detected. A new PR build was completed. |
gregsheremeta
changed the title
config/internal/apiserver/sample-pipeline/sample-pipeline.yaml.tmpl
Outdated
Show resolved
Hide resolved
gmfrasca
force-pushed
the
simply-sample-pipeline
branch
from
3a313a0 to
4a5feab
Compare
|
Change to PR detected. A new PR build was completed. |
gmfrasca
changed the title
|
/lgtm |
gmfrasca
force-pushed
the
simply-sample-pipeline
branch
from
4a5feab to
4befe3b
Compare
gmfrasca
force-pushed
the
simply-sample-pipeline
branch
from
4befe3b to
4356402
Compare
|
Change to PR detected. A new PR build was completed. |
1 similar comment
|
Change to PR detected. A new PR build was completed. |
gmfrasca
force-pushed
the
simply-sample-pipeline
branch
from
4356402 to
662a44d
Compare
|
Change to PR detected. A new PR build was completed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amadhusu, DharmitD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Resolves #annoyance
Description of your changes:
standard_scaler and min_max_scaler were effectivly mutually exclusive, so let's implement them as such to work around the issue with false-y default input params not parsing/instantiating correctly on the kfp UI.
Testing instructions
Deploy DSPO, create a v2 DSPA with
spec.apiServer.enableSamplePipeline= true. Create a run of the sample pipeline and ensure that all input parameters are populated and you can simply click 'run' without specifying anything else. Extra credit for also setting 'standard_scaler' to false and ensuring pipeline still runs with the MinMaxScaler instead of StandardScalerChecklist