Skip to content

Commit

Permalink
Add ability to mount self-signed certs to dsp v2
Browse files Browse the repository at this point in the history
  • Loading branch information
VaniHaripriya committed Feb 15, 2024
1 parent 13944b8 commit 97a0426
Showing 1 changed file with 6 additions and 11 deletions.
17 changes: 6 additions & 11 deletions backend/src/v2/compiler/argocompiler/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ func (c *workflowCompiler) containerDriverTask(name string, inputs containerDriv
},
},
}

if inputs.iterationIndex != "" {
dagTask.Arguments.Parameters = append(
dagTask.Arguments.Parameters,
Expand Down Expand Up @@ -196,7 +195,6 @@ func (c *workflowCompiler) containerExecutorTask(name string, inputs containerEx
// During runtime, it's expected that pod-spec-patch will specify command, args
// and resources etc, that are different for different tasks.
func (c *workflowCompiler) addContainerExecutorTemplate() string {

// container template is parent of container implementation template
nameContainerExecutor := "system-container-executor"
nameContainerImpl := "system-container-impl"
Expand Down Expand Up @@ -243,14 +241,12 @@ func (c *workflowCompiler) addContainerExecutorTemplate() string {
// args come from. It is treated as a strategic merge patch on
// top of the Pod spec.
PodSpecPatch: inputValue(paramPodSpecPatch),
Volumes: []k8score.Volume{
{
Name: volumeNameKFPLauncher,
VolumeSource: k8score.VolumeSource{
EmptyDir: &k8score.EmptyDirVolumeSource{},
},
Volumes: []k8score.Volume{{
Name: volumeNameKFPLauncher,
VolumeSource: k8score.VolumeSource{
EmptyDir: &k8score.EmptyDirVolumeSource{},
},
},
}},
InitContainers: []wfapi.UserContainer{{
Container: k8score.Container{
Name: "kfp-launcher",
Expand All @@ -275,8 +271,7 @@ func (c *workflowCompiler) addContainerExecutorTemplate() string {
VolumeMounts: []k8score.VolumeMount{{
Name: volumeNameKFPLauncher,
MountPath: component.VolumePathKFPLauncher,
},
},
}},
EnvFrom: []k8score.EnvFromSource{metadataEnvFrom},
Env: commonEnvs,
},
Expand Down

0 comments on commit 97a0426

Please sign in to comment.