Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick of RHOAIENG-14265 #126

Closed

Conversation

hbelmiro
Copy link

No description provided.

Signed-off-by: Helber Belmiro <[email protected]>

(cherry picked from commit 72f11d9)
Signed-off-by: Helber Belmiro <[email protected]>
(cherry picked from commit 34bf2f8)
Signed-off-by: Helber Belmiro <[email protected]>
(cherry picked from commit 2686e01)
(cherry picked from commit 37c74b3)
…ver startup

Signed-off-by: Helber Belmiro <[email protected]>
(cherry picked from commit 8ab8dae)
Copy link

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gregsheremeta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hbelmiro hbelmiro marked this pull request as ready for review January 17, 2025 14:44
@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 0 commits between d9ec34e3a0413201b529f808370bbc5d534f2a54...ac5e28b1d475115f1a680e1e835496a4a2990575

@dsp-developers
Copy link

A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-126
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-126
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-126
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-126
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-126
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-126

@dsp-developers
Copy link

An OCP cluster where you are logged in as cluster admin is required.

The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO.

To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named dspa.pr-126.yaml:

apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
  name: pr-126
spec:
  dspVersion: v2
  apiServer:
    image: "quay.io/opendatahub/ds-pipelines-api-server:pr-126"
    argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-126"
    argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-126"
  persistenceAgent:
    image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-126"
  scheduledWorkflow:
    image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-126"
  mlmd:  
    deploy: true  # Optional component
    grpc:
      image: "quay.io/opendatahub/mlmd-grpc-server:latest"
    envoy:
      image: "registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2"
  mlpipelineUI:
    deploy: true  # Optional component 
    image: "quay.io/opendatahub/ds-pipelines-frontend:pr-126"
  objectStorage:
    minio:
      deploy: true
      image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance'

Then run the following:

cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/126/head
git checkout -b pullrequest ac5e28b1d475115f1a680e1e835496a4a2990575
oc apply -f dspa.pr-126.yaml

More instructions here on how to deploy and test a Data Science Pipelines Application.

@hbelmiro hbelmiro closed this Jan 17, 2025
@dsp-developers
Copy link

Commit Checker results:

**NOTE**: These are the results of the commit checker scans. 
If these are not commits from upstream kfp, then please ensure
you adhere to the commit checker formatting
commitchecker verson unknown
Validating 0 commits between d9ec34e3a0413201b529f808370bbc5d534f2a54...ac5e28b1d475115f1a680e1e835496a4a2990575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants