Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Pipeline Schedules failing after upgrading #132

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixed Pipeline Schedules failing after upgrading #132

wants to merge 5 commits into from

Conversation

hbelmiro
Copy link

Resolves: https://issues.redhat.com/browse/RHOAIENG-14265

This PR cherry picks 4 commits from upstream and adds a new one over them.

Checklist:

@hbelmiro
UPSTREAM: 11475: fix(backend): modelToCRDTrigger was not including pe…
5376bc2 
…riodic schedule correctly (kubeflow#11475)

---------

Signed-off-by: Helber Belmiro <[email protected]>
(cherry picked from commit 97acacb)
@hbelmiro
UPSTREAM: 11480: chore(backend): Fixed namespace in job creation
6f62011 
Signed-off-by: Helber Belmiro <[email protected]>

(cherry picked from commit 72f11d9)
Signed-off-by: Helber Belmiro <[email protected]>
(cherry picked from commit 34bf2f8)
@hbelmiro
UPSTREAM: 11481: chore(backend): Fixed ServiceAccount in job creation
4e39774 
Signed-off-by: Helber Belmiro <[email protected]>
(cherry picked from commit 2686e01)
@hbelmiro
UPSTREAM: 11469: fix(backend): Synced ScheduledWorkflow CRs on apiser…
d4a6ec4 
…ver startup

Signed-off-by: Helber Belmiro <[email protected]>
(cherry picked from commit 8ab8dae)
@hbelmiro
UPSTREAM: <carry>: Fixed workflow's ServiceAccountName
499f1ea 
Signed-off-by: Helber Belmiro <[email protected]>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign accorvin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgarciao
Copy link

I've tested this PR using the dsp-api-server test image provided by @hbelmiro and scheduled workflows seem to be working fine.

  • In the testing, I've manually modified an existing ScheduledWorkflow with the following command and after restarting the dsp-api-server pod it was updated removing the incorrect fields and it kept working correctly:
oc  patch scheduledworkflow  hello-world-every-2m89bbq  -n my-project  --type='merge' -p '{"spec":{"workflow":{"spec":{"dynamicKey1":"dynamicValue1","dynamicKey2":"dynamicValue2"}}}}'

@hbelmiro hbelmiro marked this pull request as ready for review January 24, 2025 14:07
@openshift-ci openshift-ci bot requested review from gmfrasca and rimolive January 24, 2025 14:07
@hbelmiro
Copy link
Author

@HumairAK @mprahl can you PTAL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmfrasca gmfrasca Awaiting requested review from gmfrasca

@rimolive rimolive Awaiting requested review from rimolive

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbelmiro @jgarciao