Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace unresolved dependency #139

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

HumairAK
Copy link

@HumairAK HumairAK commented Feb 14, 2025

Resolve this error:

go: nhooyr.io/[email protected]: invalid version: unknown revision v1.8.6

By updating: gocloud.dev => v0.40.0 (where the dependency comes from)

See more details here: https://coder.com/blog/websocket

This emulates the changes here kubeflow@c100648#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6

The WF changes are borrowed from kubeflow@e89d2d5#diff-4221e7060cb5692b5e8656f8f092468895f4bc8804397e8de7cb4cfdf8d95024 , to get by the go.mod errors where it fails to recognize the "x.y.z" format for the go version.

i.e. invalid go version '1.21.0': must match format 1.23

But we don't cherry pick the whole thing here since we just need the dependency update to unblock the release.

nhooyr.io maintenance has been taken over by github.copm/coder

Signed-off-by: Humair Khan <[email protected]>
Copy link
Member

@gmfrasca gmfrasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK
Copy link
Author

ignoring kftp tekton tests

@HumairAK HumairAK merged commit 9f41501 into opendatahub-io:master Feb 14, 2025
4 of 5 checks passed
@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-139
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-139
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-139
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-139
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-139
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-139

1 similar comment
@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-139
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-139
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-139
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-139
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-139
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants