-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace unresolved dependency #139
Conversation
1ae814e
to
bdb844d
Compare
nhooyr.io maintenance has been taken over by github.copm/coder Signed-off-by: Humair Khan <[email protected]>
bdb844d
to
43c30db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ignoring kftp tekton tests |
Change to PR detected. A new PR build was completed. |
1 similar comment
Change to PR detected. A new PR build was completed. |
Resolve this error:
By updating: gocloud.dev => v0.40.0 (where the dependency comes from)
See more details here: https://coder.com/blog/websocket
This emulates the changes here kubeflow@c100648#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6
The WF changes are borrowed from kubeflow@e89d2d5#diff-4221e7060cb5692b5e8656f8f092468895f4bc8804397e8de7cb4cfdf8d95024 , to get by the go.mod errors where it fails to recognize the "x.y.z" format for the go version.
i.e.
invalid go version '1.21.0': must match format 1.23
But we don't cherry pick the whole thing here since we just need the dependency update to unblock the release.