Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make istio ingress gateway and control plane properties environment variables, to support external smcp, fixes RHOAIENG-19912 #200

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

dhirajsb
Copy link
Contributor

Description

Add env variables in operator to allow connecting to an external smcp and ingress gateway.

How Has This Been Tested?

Tested manually by installing locally and applying local odh configuration generated with:

kustomize build config/overlays/odh

Generated odh overlay operator deployment uses env variables populated from odh operator configmap service-mesh-refs.
Verified that creating an MR with the new operator produces the following in the spec defaults:

,"gateway":{"controlPlane":"data-science-smcp","domain":"apps.rosa.dbokde-cluster.2rkm.p3.openshiftapps.com","istioIngress":"ingressgateway"}}

Note that the ingress gateway odh configmap property is optional, as an update is needed in ODH operator to pass that information to the MR operator in the future. The MR operator sets the value to the previous default ingressgateway.

Merge criteria:

  • The commits and have meaningful messages; the author will squash them after approval or will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@dhirajsb dhirajsb requested review from Al-Pragliola and a team February 14, 2025 00:51
Copy link
Contributor

@Al-Pragliola Al-Pragliola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

tested locally and everything seems to work, checked for backward compatibility

@dhirajsb dhirajsb merged commit b8c51e8 into opendatahub-io:main Feb 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants