fix: make istio ingress gateway and control plane properties environment variables, to support external smcp, fixes RHOAIENG-19912 #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add env variables in operator to allow connecting to an external smcp and ingress gateway.
How Has This Been Tested?
Tested manually by installing locally and applying local odh configuration generated with:
Generated odh overlay operator deployment uses env variables populated from odh operator configmap service-mesh-refs.
Verified that creating an MR with the new operator produces the following in the spec defaults:
,"gateway":{"controlPlane":"data-science-smcp","domain":"apps.rosa.dbokde-cluster.2rkm.p3.openshiftapps.com","istioIngress":"ingressgateway"}}
Note that the ingress gateway odh configmap property is optional, as an update is needed in ODH operator to pass that information to the MR operator in the future. The MR operator sets the value to the previous default
ingressgateway
.Merge criteria: