Skip to content

Commit

Permalink
nav tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
jeff-phillips-18 committed Feb 4, 2025
1 parent 010e9cb commit 076e13c
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 14 deletions.
9 changes: 2 additions & 7 deletions frontend/src/pages/modelCatalog/ModelCatalogCoreLoader.tsx
Original file line number Diff line number Diff line change
@@ -1,15 +1,10 @@
import * as React from 'react';
import { conditionalArea, SupportedArea } from '~/concepts/areas';
import ApplicationsPage from '~/pages/ApplicationsPage';
import TitleWithIcon from '~/concepts/design/TitleWithIcon';
import { ProjectObjectType, typedEmptyImage } from '~/concepts/design/utils';
import EmptyModelCatalogState from './EmptyModelCatalogState';

const ModelCatalogCoreLoader: React.FC = conditionalArea(
SupportedArea.MODEL_CATALOG,
true,
)(() => {
console.log(`========== ModelCatalogCoreLoader ==========`);
const ModelCatalogCoreLoader: React.FC = () => {
const renderStateProps = {
empty: true,
emptyStatePage: (
Expand All @@ -34,6 +29,6 @@ const ModelCatalogCoreLoader: React.FC = conditionalArea(
provideChildrenPadding
/>
);
});
};

export default ModelCatalogCoreLoader;
22 changes: 15 additions & 7 deletions frontend/src/utilities/NavData.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
artifactsRootPath,
executionsRootPath,
experimentsRootPath,
pipelineRunsRootPath,
pipelinesRootPath,
} from '~/routes';
import { useUser } from '~/redux/selectors';
Expand Down Expand Up @@ -61,13 +62,11 @@ const useDistributedWorkloadsNav = (): NavDataHref[] =>
const useDevelopAndTrainNav = (): NavDataItem[] => [
{
id: 'developAndTrain',
group: { id: 'developAndTrain', label: 'Develop and Train', icon: <ProcessAutomationIcon /> },
group: { id: 'developAndTrain', label: 'Develop and train', icon: <ProcessAutomationIcon /> },
children: [
{ id: 'notebooks', label: 'Workbenches', href: '/workbenches' },
{ id: 'experimentsAndRuns', label: 'Experiments and runs', href: experimentsRootPath },
{ id: 'executions', label: 'Executions', href: executionsRootPath },
{ id: 'experiments', label: 'Experiments', href: experimentsRootPath },
{ id: 'artifacts', label: 'Artifacts', href: artifactsRootPath },
...useDistributedWorkloadsNav(),
],
},
];
Expand All @@ -79,7 +78,7 @@ const useManageModelsNav = (): NavDataItem[] =>
id: 'manageModels',
group: { id: 'manageModels', label: 'Models', icon: <ModelIcon /> },
children: [
{ id: 'modelCatalog', label: 'Model Catalog', href: '/modelCatalog' },
{ id: 'modelCatalog', label: 'Model catalog', href: '/modelCatalog' },
{ id: 'modelRegistry', label: 'Model registry', href: '/modelRegistry' },
{ id: 'modelDeployments', label: 'Model deployments', href: '/modelServing' },
],
Expand All @@ -90,7 +89,7 @@ const useManageModelsNav = (): NavDataItem[] =>
id: 'manageModels',
group: { id: 'manageModels', label: 'Models', icon: <ModelIcon /> },
children: [
{ id: 'modelOverview', label: 'Model overview', href: '/modelOverview' },
{ id: 'modelOverview', label: 'Model catalog', href: '/modelCatalog' },
{ id: 'modelDeployments', label: 'Model deployments', href: '/modelServing' },
],
},
Expand All @@ -100,7 +99,15 @@ const useAutomateNav = (): NavDataItem[] => [
{
id: 'automate',
group: { id: 'automate', label: 'Automate', icon: <AutomationIcon /> },
children: [{ id: 'pipelines', label: 'Pipelines', href: pipelinesRootPath }],
children: [
{ id: 'pipelines', label: 'Pipelines', href: pipelinesRootPath },
{
id: 'runs',
label: 'Runs',
href: pipelineRunsRootPath,
},
{ id: 'executions', label: 'Executions', href: executionsRootPath },
],
},
];

Expand All @@ -111,6 +118,7 @@ const useConfigureNav = (): NavDataItem[] => [
children: [
{ id: 'connections', label: 'Connections', href: '/connections' },
{ id: 'clusterStorage', label: 'Cluster storage', href: '/clusterStorage' },
...useDistributedWorkloadsNav(),
{ id: 'applications', label: 'Applications', href: '/applications' },
],
},
Expand Down

0 comments on commit 076e13c

Please sign in to comment.