-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BYON Improvements Phase 1 to main
#1997
Conversation
Refactor BYON images table
Update modals and generate meaningful k8s name for images
Fix byon branch type issues
Minor UX fixes for custom notebook images
added empty state test
BYON tests added
/hold Until proper sign-offs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Looked through the code and tested on the cluster, worked great and nothing is broken.
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: DaoDaoNoCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: #1254
Description
Merges the phase 1 improvements to the Custom Notebook
How Has This Been Tested?
Manually and through existing tests.
More will need to be done on cluster to verify parity.
Test Impact
Tests exist now for the feature, this PR just merges into
main
.Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main