Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BYON Improvements Phase 1 to main #1997

Merged
merged 20 commits into from
Oct 20, 2023
Merged

BYON Improvements Phase 1 to main #1997

merged 20 commits into from
Oct 20, 2023

Conversation

andrewballantyne
Copy link
Member

@andrewballantyne andrewballantyne commented Oct 20, 2023

Closes: #1254

Description

Merges the phase 1 improvements to the Custom Notebook

How Has This Been Tested?

Manually and through existing tests.

More will need to be done on cluster to verify parity.

Test Impact

Tests exist now for the feature, this PR just merges into main.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

uidoyen and others added 20 commits June 28, 2023 14:23
Update modals and generate meaningful k8s name for images
Minor UX fixes for custom notebook images
@openshift-ci openshift-ci bot requested review from alexcreasy and pnaik1 October 20, 2023 15:29
@andrewballantyne andrewballantyne changed the title F/byon BYON Improvements Phase 1 to main Oct 20, 2023
@andrewballantyne
Copy link
Member Author

/hold

Until proper sign-offs

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Oct 20, 2023
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Looked through the code and tested on the cluster, worked great and nothing is broken.

@andrewballantyne andrewballantyne added approved and removed do-not-merge/hold This PR is hold for some reason labels Oct 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: DaoDaoNoCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit ed8673f into main Oct 20, 2023
3 checks passed
@andrewballantyne andrewballantyne deleted the f/byon branch November 23, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracker] Custom Notebook (BYON) Improvements - Part 1
6 participants