migrate e2e test for adding group permission

[gitdallas]

closes: RHOAIENG-17420

Description

migrating test that user can add group as admin for project

How Has This Been Tested?

• An oc login should be performed in the cluster before running the test
• test-variables.yml should be configured properly
• Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml
• Locally against a PSI cluster and ODH-Nightly

How to run?
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testProjectAdminPermissions.cy.ts can be run.

Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/dataScienceProjects/testProjectAdminPermissions.cy.ts" --browser chrome

or Execute 'npx cypress run --env grepTags=@ODS-2208'

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.23%. Comparing base (d4b9a46) to head (ba541ed).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3683      +/-   ##
==========================================
- Coverage   84.23%   84.23%   -0.01%     
==========================================
  Files        1459     1459              
  Lines       33728    33728              
  Branches     9354     9354              
==========================================
- Hits        28412    28411       -1     
- Misses       5316     5317       +1     

Files with missing lines	Coverage Δ
...ts/roleBinding/RoleBindingPermissionsNameInput.tsx	96.29% <ø> (ø)

... and 7 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4b9a46...ba541ed. Read the comment docs.

[ConorOM1]

@gitdallas can you update the PR details to follow the same format as #3686 thank you !

[ConorOM1]

/lgtm

[antowaddle]

@gitdallas Thanks for creating this test, really appreciated.

I've tried to execute this test against the latest Dashboard version, the test passed the first time but failed intermittently thereafter. Can you execute this test against the latest Dashboard code a few times and see if you see the same issue?

[gitdallas]

@antowaddle - it passed for me in CI, headless several times, and in the cypress browser several times.. but i noticed that it's not creating a dropdown menu for the name of the group, which it should... so changes are needed, and i may need some assistance figuring out the data here. maybe we can meet sometime tomorrow.

[antowaddle]

@antowaddle - it passed for me in CI, headless several times, and in the cypress browser several times.. but i noticed that it's not creating a dropdown menu for the name of the group, which it should... so changes are needed, and i may need some assistance figuring out the data here. maybe we can meet sometime tomorrow.

@gitdallas Sure, no problem at all. Ping me when you are online and we can review.

[gitdallas]

@antowaddle - figured it out, but had to use some more complex selectors as we were missing a testid. i've added it so perhaps we can update it later and/or use for future tests.

[antowaddle]

@gitdallas I pulled your branch, then launched the dashboard locally while connected to the e2e cluster. The test passes when launched locally via Cypress UI, but when I tried to launch it headlessly it fails.

Can you try please? npx cypress run --env grepTags=@ODS-2208 --browser chrome

I believe if we use multiple 'its' within a describe block, the tags in the tests should all be the same if projects are shared between the 'it' blocks.

[gitdallas]

@antowaddle - very odd this would work in one but not the other, i changed how the selection is made and it seems to work now in both ways.

[antowaddle]

Works fine now for me

[antowaddle]

/lgtm /approved

[antowaddle]

/approve

[manosnoam]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antowaddle, manosnoam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [manosnoam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment