-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update routing flow for creating accelerator/hardware profile on custom notebook image table #3688
Update routing flow for creating accelerator/hardware profile on custom notebook image table #3688
Conversation
…om notebook image table
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3688 +/- ##
==========================================
- Coverage 84.16% 84.16% -0.01%
==========================================
Files 1453 1454 +1
Lines 33865 33883 +18
Branches 9384 9390 +6
==========================================
+ Hits 28503 28516 +13
- Misses 5362 5367 +5
... and 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
frontend/src/pages/acceleratorProfiles/screens/manage/ManageAcceleratorProfileFooter.tsx
Show resolved
Hide resolved
frontend/src/pages/hardwareProfiles/manage/ManageHardwareProfileFooter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/screens/manage/ManageAcceleratorProfileFooter.tsx
Outdated
Show resolved
Hide resolved
…celeratorProfileFooter.tsx
frontend/src/pages/acceleratorProfiles/screens/manage/ManageAcceleratorProfileFooter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/hardwareProfiles/manage/ManageHardwareProfileFooter.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/acceleratorProfiles/screens/manage/ManageAcceleratorProfileFooter.tsx
Outdated
Show resolved
Hide resolved
…celeratorProfileFooter.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dc692b5
into
opendatahub-io:main
JIRA: RHOAIENG-1458
Description
Create separate routes for creating accelerator profile and hardware profile on the notebook image table. In that case, when creating it, the navigation could be more reasonable and clear.
Take hardware profile as an example, click on "Create profile" on any row
Now the creation page still sits under the notebook image settings context - You can check the breadcrumb and the side nav highlight
Click on "Cancel", it will take you back to the notebook settings table
When successfully creating, it will take you back to the notebook image table and show a notification with a link
Clicking on the link, it will take you to the edit page of that hardware profile
It's the same flow for accelerator profile if the hardware profile is disabled
How Has This Been Tested?
Test Impact
N/A, there are currently no test cases for this row, not sure if it's worth the effort for the accelerator profile, we can do that later for the hardware profile.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main