Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress e2e Test - Verifies users can create, edit and delete a Persistent Volume #3689

Merged

Conversation

antowaddle
Copy link
Contributor

@antowaddle antowaddle commented Jan 28, 2025

https://issues.redhat.com/browse/RHOAIENG-17427

Description

  • Migrate 'Verifies users can create/delete a PersistentVolume' to Cypress ODS-1824
    -This test focuses on PVC management through the user interface (UI). It encompasses the following key steps and verifications:
  1. PVC Creation: Initiates the process by creating a new Persistent Volume Claim via the UI.
  2. Dashboard Configuration Check: Verifies the PVC value in the dashboard configuration to ensure it matches the expected settings.
  3. UI Consistency Verification: Compares the dashboard configuration PVC value with the corresponding value displayed on the UI, ensuring consistency across the system.
  4. PVC Editing: Incorporates functionality to edit the existing PVC, allowing for testing of modification capabilities.
  5. PVC Deletion: Concludes by deleting the created PVC, testing the complete lifecycle of a Persistent Volume Claim.

How Has This Been Tested?

  • An oc login should be performed in the cluster before running the test
  • test-variables.yml should be configured properly
  • Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml
  • Locally against a PSI cluster and ODH-Nightly
    image

Test Impact

  • None - this is a test

How to run?
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where testClusterStorageCreation.cy.ts can be run.

Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/dataScienceProjects/clusterStorage/testClusterStorageCreation.cy.ts" --browser chrome

or Execute 'npx cypress run --env grepTags=@ODS-1824'

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

antowaddle and others added 30 commits November 20, 2024 17:07
increase card timeout and delete active wait
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.14%. Comparing base (3167270) to head (2535e00).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3689      +/-   ##
==========================================
- Coverage   84.16%   84.14%   -0.03%     
==========================================
  Files        1453     1453              
  Lines       33865    33865              
  Branches     9384     9384              
==========================================
- Hits        28504    28496       -8     
- Misses       5361     5369       +8     

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3167270...2535e00. Read the comment docs.

@ConorOM1
Copy link
Contributor

@antowaddle maybe we could include editing also ? Or have we a separate test for this ?

@ConorOM1
Copy link
Contributor

the PR description mentions data connections ? This is for PV storage right ?

@antowaddle
Copy link
Contributor Author

the PR description mentions data connections ? This is for PV storage right ?

@ConorOM1 Yes, good spot. Amended now.

@antowaddle
Copy link
Contributor Author

@antowaddle maybe we could include editing also ? Or have we a separate test for this ?

@ConorOM1 I'm not sure if we have a specific test case for this, but I've added it to this test.

@antowaddle antowaddle requested a review from ConorOM1 January 28, 2025 16:41
@antowaddle antowaddle changed the title Cypress e2e Test - Verifies users can create/delete a Persistent Volume Cypress e2e Test - Verifies users can create, edit and delete a Persistent Volume Jan 28, 2025
@ConorOM1
Copy link
Contributor

nice work @antowaddle !

@ConorOM1
Copy link
Contributor

/lgtm

Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manosnoam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2e6e823 into opendatahub-io:main Jan 29, 2025
29 checks passed
@antowaddle antowaddle deleted the cypress-RHOAIENG-17427 branch January 29, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants