Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point as a Geometry #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Point as a Geometry #55

wants to merge 2 commits into from

Conversation

jvdadda
Copy link

@jvdadda jvdadda commented Apr 28, 2020

According to GeoJson specifications (RFC 7946), a Point is a Geometry.

  • Update Geometry object and all sub objects to accept a generic type T instead of a List in order to accept Point as a Geometry
  • Make Point a Geometry

@jvdadda
Copy link
Author

jvdadda commented Apr 28, 2020 •
edited
Loading

List of modifications that will follow this one when accepted:

  • Now that Point is a Geometry, GeometryCollection can accept only Geometry instead of GeoJsonObject
  • GeometryCollection should be a Geometry too
  • Feature should accept only Geometry and not a GeoJsonObject

@jasonCodesAway
Copy link

Can someone please accept this PR!?!?

@grundid
Copy link
Member

grundid commented Jul 30, 2020

Will do a 2.0 release from this PR

@ajakz
Copy link

ajakz commented Oct 15, 2021

Will do a 2.0 release from this PR

Is this still going to happen...?

@frett27
Copy link

frett27 commented Apr 20, 2024

i made the same modification on, my side, this is a good modeling element, permitting to differenciate Features / Collections and geometries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jvdadda @jasonCodesAway @grundid @ajakz @frett27