Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feat/upgrade celery #2820

Closed
wants to merge 17 commits into from
Closed

[WIP] Feat/upgrade celery #2820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
fde1100
WIP upgrading flask
maudetes Feb 8, 2023
a3af99c
Are we good with flask-login and security ?
maudetes Feb 9, 2023
7744fce
Check for blueprints being registered
maudetes Feb 9, 2023
c60b501
We can't use werkzeug Href anymore
maudetes Feb 9, 2023
953fb2d
Specify _external=True on all redirect urls
maudetes Feb 9, 2023
79b7225
Prepare to test udata-front
maudetes Feb 9, 2023
be55747
Fix custom security template rendering logic
maudetes Feb 17, 2023
a438bcf
Get lazystring value before serializing mail for celery
maudetes Feb 27, 2023
f876bc0
Simpler url encoding
maudetes Feb 27, 2023
1815099
Use unique blueprint name in storage tests
maudetes Feb 27, 2023
2e1db19
Get info settings from ctx since script info param is deprecated
maudetes Feb 27, 2023
c0d83cc
Don't need to specify absolute url on redirect
maudetes Feb 28, 2023
1a8356d
Fix flask caching deprecated cache_type
maudetes Feb 28, 2023
6378989
Recompute .pip requirements
maudetes Feb 28, 2023
6bc01ab
Add changelog
maudetes Feb 28, 2023
621a730
Remove TODO
maudetes Feb 28, 2023
fc349df
Upgrade deps (celery and everything that follows)
maudetes Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## Current (in progress)

- :warning: Upgrading Flask to 2.1.2, leading to an upgrade of click (8.0), Flask-BabelEx (0.9.4), Flask-Caching (2.0.2), flask-storage (1.0.0) instead of flask-fs, Flask-Login (0.6.2), flask-restx (1.0.5), Flask-Security-Too (4.1.5), Jinja2 (3.1.2), pillow (9.2.0), werkzeug (2.2.2) [#2816](https://github.com/opendatateam/udata/pull/2816)
- Use the full path to the caching backend in `CACHE_TYPE`, ex: `flask_caching.backends.redis`. Named backends are deprecated.
- Werkzeug redirect now returns the relative url as location in response (https://github.com/pallets/werkzeug/issues/2352).
- Removed functions have been replaced (`contextfilter` and `contextfunction` from Jinja, root imports and `Href` from Werkzeug, `JSONWebSignatureSerializer` from itsdangerous)
- Prevent multiple blueprint with same name registration (not supported anymore in Flask).
- Removed all code logic related to the `published` date in resource model, now deprecated. :warning: The attribute itself was left in the model because of the complexity of the migration [#2807](https://github.com/opendatateam/udata/pull/2807)
- Add `xlsx` and `docx` as closed format for quality score [#2814](https://github.com/opendatateam/udata/pull/2814)

Expand Down
4 changes: 2 additions & 2 deletions docs/adapting-settings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,9 +451,9 @@ You can see the full options list in

### CACHE_TYPE

**default**: `'redis'`
**default**: `'flask_caching.backends.redis'`

The cache type, which can be adjusted to your needs (_ex:_ `null`, `memcached`)
The cache type, which can be adjusted to your needs (_ex:_ `null`, `flask_caching.backends.memcached`)

### CACHE_KEY_PREFIX

Expand Down
2 changes: 1 addition & 1 deletion docs/getting-started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ from udata.settings import Defaults
DEBUG = True
SEND_MAIL = False
SERVER_NAME ='dev.local:7000'
CACHE_TYPE = 'null'
CACHE_TYPE = 'flask_caching.backends.null'

URLS_ALLOW_PRIVATE = True
URLS_ALLOW_LOCAL = True
Expand Down
2 changes: 1 addition & 1 deletion docs/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ CELERY_RESULT_BACKEND = 'redis://localhost:6379'
CELERY_TASK_RESULT_EXPIRES = 86400

# We use Redis as caching backend but in a separate collection
CACHE_TYPE = 'redis'
CACHE_TYPE = 'flask_caching.backends.redis'
CACHE_REDIS_URL = 'redis://localhost:6379/2'

# The identity used to send mails
Expand Down
Loading