Convert bool filters to 0 or 1 when querying the search service #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magopian
commented
Nov 19, 2024
Comment on lines
+26
to
+28
| # This is needed or the test will fail if you have a search service configured in your udata.cfg file. | ||
| current_app.config["SEARCH_SERVICE_API_URL"] = "" | ||
|
|
There was a problem hiding this comment.
This is unrelated to this PR, but this test will fail if you have a search service configured, which I needed to fix this PR ;)
magopian
commented
Nov 19, 2024
Comment on lines
+56
to
+57
| # This is needed or the test will fail if you have a search service configured in your udata.cfg file. | ||
| current_app.config["SEARCH_SERVICE_API_URL"] = "" |
There was a problem hiding this comment.
This is unrelated to this PR, but this test will fail if you have a search service configured, which I needed to fix this PR ;)
magopian
requested review from
maudetes and
bolinocroustibat
and removed request for
maudetes
maudetes
reviewed
Nov 22, 2024
| # HACK: use the `.__class__.__name__` to avoid having to import `BoolFilter` here, as importing it at the top would make a import loop. | ||
| if self.adapter.filters[name].__class__.__name__ == "BoolFilter": | ||
| # The search service uses 1 and 0 for booleans. | ||
| param_value = 1 if value == "true" else 0 |
There was a problem hiding this comment.
Somehow on udata-search-service side, featured is not set to 0 or 1 but 1 or 4 (probably for poorly decided scoring reasons) 🥲
| # HACK: use the `.__class__.__name__` to avoid having to import `BoolFilter` here, as importing it at the top would make a import loop. | ||
| if self.adapter.filters[name].__class__.__name__ == "BoolFilter": | ||
| # The search service uses 1 and 0 for booleans. | ||
| param_value = 1 if value == "true" else 0 |
There was a problem hiding this comment.
I think if value is True and not true when it comes from the udata-front search view: /fr/datasets/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1456