Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #231 - Refactor RoutingResources with OpenDCS DAIs #257

Conversation

zack-rma
Copy link
Collaborator

@zack-rma zack-rma commented Dec 4, 2024

Problem Description

Fixes #231.

Solution

Replaces DAO usage with OpenDCS DAI/DAO implementations.

how you tested the change

Unit testing in PR.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

If you aren't sure leave unchecked and we will help guide you to want needs changing where.

@zack-rma
Copy link
Collaborator Author

zack-rma commented Dec 4, 2024

A few CRUD functions may need updated OpenDCS DAI implementations to complete this task

@zack-rma zack-rma force-pushed the feature/replace_algorithm_dao_routing_resources branch from 7bbb6c0 to 90f458a Compare December 5, 2024 17:02
@zack-rma
Copy link
Collaborator Author

zack-rma commented Dec 6, 2024

Methods with return codes of "NOT_IMPLEMENTED" may need new DAI method implementations in OpenDCS to match functionality

@zack-rma zack-rma changed the base branch from main to feature/replace_algorithm_dao December 9, 2024 20:31
@zack-rma zack-rma force-pushed the feature/replace_algorithm_dao_routing_resources branch from 90f458a to 711cca0 Compare December 10, 2024 22:36
@zack-rma zack-rma force-pushed the feature/replace_algorithm_dao_routing_resources branch from 3efe858 to 9e1dee5 Compare December 14, 2024 01:06
@zack-rma
Copy link
Collaborator Author

New PR here: #280

@zack-rma zack-rma closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor RoutingResources controller
1 participant